NVMeCache: move the completion callback into MetricStore

The completion callback is used to trigger MetricUpdate signal on the
MetricStore interface. Thus moving the callback implementation from the
Metric constructor to MetricStore constructor will reduce code
duplication.

It also benefits when the Metric creator is not the owner of
MetricStore, e.g. the plugin classes. In this case, the Metric owner can
transfer the ownship of Metric to the MetricStore to present it on the
DBus.

To accomplish above, adding a new interface to NVMeCache that pushes the
complete callbacks to the Metric instance. Unlike the callback by
refresh() function, the complete callback will not pop up after the
refresh completion.

Google-Bug-Id: 348660385#comment14
Tested: b/348660385#comment15
Signed-off-by: Hao Jiang <jianghao@google.com>
Change-Id: I23075272e7803374087aa607f8aa22fe09f226ee
6 files changed
tree: 81f4558c35a0dd7beabce9ca5ea0b41f039bf1ca
  1. gen/
  2. include/
  3. service_files/
  4. src/
  5. subprojects/
  6. tests/
  7. yaml/
  8. .clang-format
  9. .clang-tidy
  10. .clang-tidy-ignore
  11. .gitignore
  12. LICENSE
  13. meson.build
  14. meson_options.txt
  15. OWNERS
  16. README.md
README.md

dbus-sensors

dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.

key features

  • runtime re-configurable from d-bus (entity-manager or the like)

  • isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible

  • async single-threaded: uses sdbusplus/asio bindings

  • multiple data inputs: hwmon, d-bus, direct driver access

dbus interfaces

A typical dbus-sensors object support the following dbus interfaces:

Path        /xyz/openbmc_project/sensors/<type>/<sensor_name>

Interfaces  xyz.openbmc_project.Sensor.Value
            xyz.openbmc_project.Sensor.Threshold.Critical
            xyz.openbmc_project.Sensor.Threshold.Warning
            xyz.openbmc_project.State.Decorator.Availability
            xyz.openbmc_project.State.Decorator.OperationalStatus
            xyz.openbmc_project.Association.Definitions

Sensor interfaces collection are described here.

Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.

Reactor

dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.

Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.

A simple sensor example can be found here.

configuration

Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.

sensor documentation