nvmed: reset featureStore in NVMeSubsystem::markFunctional(false)

When MCTP reactor restarts or the MCTP endpoint disconnects,
NVMeSubsystem::markFunctional(false) clears attached volumes and
controllers, but previously omitted resetting featureStore.

As a result, featureStore retained a dangling pointer to nvme_mi_ctrl_t
which was freed when the MCTP connection closed. When the endpoint
reconnected, initializeFeatureStore() exited early because featureStore
was already populated, preserving the stale controller reference.
Subsequent NVMe admin queries (such as nvme_mi_admin_get_log) then
accessed the freed memory, causing a SIGSEGV crash.

Reset featureStore in NVMeSubsystem::markFunctional(false) so that
the stale FeatureStore is properly destroyed and recreated with the
new controller upon reconnection.

Tested: Ran unit tests.
Google-Bug-Id: 565728782
Change-Id: Iae25de23fcd80373c4089365991233cb30a33395
Signed-off-by: Guangzong Chen <guangzong@google.com>
TAG=agy
CONV=05ec5ee7-d8a8-4299-9bd5-92c2d10bad16
1 file changed
tree: 97e1dac9321a578681ec95d5775bbc35073fc48d
  1. .agents/
  2. gen/
  3. include/
  4. proto/
  5. service_files/
  6. src/
  7. subprojects/
  8. tests/
  9. yaml/
  10. .clang-format
  11. .clang-tidy
  12. .clang-tidy-ignore
  13. .gitignore
  14. LICENSE
  15. meson.build
  16. meson_options.txt
  17. OWNERS
  18. README.md
README.md

dbus-sensors

dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.

key features

  • runtime re-configurable from d-bus (entity-manager or the like)

  • isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible

  • async single-threaded: uses sdbusplus/asio bindings

  • multiple data inputs: hwmon, d-bus, direct driver access

dbus interfaces

A typical dbus-sensors object support the following dbus interfaces:

Path        /xyz/openbmc_project/sensors/<type>/<sensor_name>

Interfaces  xyz.openbmc_project.Sensor.Value
            xyz.openbmc_project.Sensor.Threshold.Critical
            xyz.openbmc_project.Sensor.Threshold.Warning
            xyz.openbmc_project.State.Decorator.Availability
            xyz.openbmc_project.State.Decorator.OperationalStatus
            xyz.openbmc_project.Association.Definitions

Sensor interfaces collection are described in Sensor interfaces.

Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.

Reactor

dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.

Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.

A simple sensor example can be found in the my_first_sensors example.

configuration

Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.

sensor documentation