nvmed: do not register FeatureStore on identify failure When a drive is absent or fails to respond to Identify Controller during FeatureStore initialization, do not attempt to discover features or register the FeatureStore D-Bus interface. Previously, if Identify Controller failed, oncs remained 0, which caused oncsBit4 to evaluate to false. In discoverFeatures, the !oncsBit4 fallback path unconditionally populated all default features into featureCollection and exposed xyz.openbmc_project.NVMe.FeatureStore on D-Bus. Redfish clients querying feature endpoints on absent slots then experienced D-Bus call failures mapped to HTTP 500 Internal Error. With this change, fetchIdentifyData returns false on error, skipping discoverFeatures and D-Bus interface registration, and resets the featureStore pointer in controller, subsystem, and volume classes. Tested: Ran unit tests. Google-Bug-Id: 555312695 Change-Id: I6e4e93184269fc95a5faccb42d5da5f73ed9abff Signed-off-by: Guangzong Chen <guangzong@google.com> TAG=agy CONV=b4ce846a-32f5-46f9-8f8e-b66c6d95ea2b
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access
A typical dbus-sensors object support the following dbus interfaces:
Path /xyz/openbmc_project/sensors/<type>/<sensor_name> Interfaces xyz.openbmc_project.Sensor.Value xyz.openbmc_project.Sensor.Threshold.Critical xyz.openbmc_project.Sensor.Threshold.Warning xyz.openbmc_project.State.Decorator.Availability xyz.openbmc_project.State.Decorator.OperationalStatus xyz.openbmc_project.Association.Definitions
Sensor interfaces collection are described in Sensor interfaces.
Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.
dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.
Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.
A simple sensor example can be found in the my_first_sensors example.
Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.