Fix 9 IncludeCleaner findings:
* Used header "production/sushid/safepower_agent/proto/safepower_agent.proto.h" is not included directly (3 times)
* Used header "production/sushid/safepower_agent/proto/state_persistence.proto.h" is not included directly (2 times)
* Used header "third_party/absl/strings/str_format.h" is not included directly
* Used header <iostream> is not included directly
* Used header "production/sushid/safepower_agent/proto/safepower_agent_config.proto.h" is not included directly
* Used header "google/protobuf/timestamp.proto.h" is not included directly
⚠️ Problems with this CL?
Click the "Roll back" button above, write a description of the problem (ideally with supporting logs/dashboards/screenshots) and a human global approver will be assigned to review the generated rollback CL.
* See go/include-cleaner for more information about the tool that generated this change.
* The global approvers for this change category are currently piloting the go/reviewbot tool so you may see global-review-bot-composite as the approver. Please contact code-health-team@google.com if you have any questions/concerns about the approval process.
See go/include-cleaner-lsc-approval for more information on why you've received this change and why it is important.
This CL looks good? Just LGTM and Approve it!
This CL doesn’t look good? This is what you can do:
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/include-cleaner-bug for category IncludeCleaner if there's an issue with the CL content.
* File a bug under go/rosie-bug if there's an issue with how the CL was managed.
* For all other issues such as the formatting of the CL, please file a bug under
go/clrobot-bug.
* Revert this CL and not get a CL that cleans up these paths in the future by
replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.
This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/METADATA by
following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug
at go/clrobot-bug.
#codehealth
Tested:
Local presubmit tests passed.
PiperOrigin-RevId: 726808700
Change-Id: I4b74d18c0d3b7b8dd8ba700a63cbbe6d8f80b7f9
diff --git a/bmc/http_connection.cc b/bmc/http_connection.cc
index 8dec749..1190fdd 100644
--- a/bmc/http_connection.cc
+++ b/bmc/http_connection.cc
@@ -11,6 +11,7 @@
#include "absl/status/status.h"
#include "absl/status/statusor.h"
#include "absl/strings/str_cat.h"
+#include "absl/strings/str_format.h"
#include "absl/strings/string_view.h"
#include "absl/time/time.h"
diff --git a/bmc/persistent_storage_bmc.cc b/bmc/persistent_storage_bmc.cc
index 0010a66..6825a7f 100644
--- a/bmc/persistent_storage_bmc.cc
+++ b/bmc/persistent_storage_bmc.cc
@@ -11,8 +11,11 @@
#include <system_error> // NOLINT(build/c++11)
#include <vector>
+#include "google/protobuf/timestamp.pb.h"
#include "action_context.h"
#include "bmc/proto_reader.h"
+#include "safepower_agent.pb.h"
+#include "state_persistence.pb.h"
#include "absl/log/log.h"
#include "absl/status/status.h"
#include "absl/status/statusor.h"
diff --git a/bmc/persistent_storage_bmc.h b/bmc/persistent_storage_bmc.h
index aec1b85..5d9dec1 100644
--- a/bmc/persistent_storage_bmc.h
+++ b/bmc/persistent_storage_bmc.h
@@ -6,6 +6,7 @@
#include <vector>
#include "persistent_storage.h"
+#include "state_persistence.pb.h"
#include "absl/status/status.h"
#include "absl/status/statusor.h"
#include "absl/strings/string_view.h"
diff --git a/bmc/register_actions_bmc.cc b/bmc/register_actions_bmc.cc
index f5097ec..7655293 100644
--- a/bmc/register_actions_bmc.cc
+++ b/bmc/register_actions_bmc.cc
@@ -9,6 +9,8 @@
#include "action_context.h"
#include "bmc/http_connection.h"
+#include "safepower_agent.pb.h"
+#include "safepower_agent_config.pb.h"
#include "absl/functional/any_invocable.h"
#include "absl/log/log.h"
#include "absl/status/status.h"
diff --git a/bmc/register_actions_bmc_test.cc b/bmc/register_actions_bmc_test.cc
index 7ac9aa3..47f2471 100644
--- a/bmc/register_actions_bmc_test.cc
+++ b/bmc/register_actions_bmc_test.cc
@@ -11,6 +11,7 @@
#include <vector>
#include "action_context.h"
+#include "safepower_agent.pb.h"
#include "safepower_agent_config.pb.h"
#include "state_updater.h"
#include "gmock/gmock.h"
diff --git a/bmc/scheduler_bmc_test.cc b/bmc/scheduler_bmc_test.cc
index c84428f..f3ed3d3 100644
--- a/bmc/scheduler_bmc_test.cc
+++ b/bmc/scheduler_bmc_test.cc
@@ -2,6 +2,7 @@
#include "bmc/scheduler_bmc.h"
#include <chrono> // NOLINT(build/c++11)
+#include <iostream>
#include <memory>
#include <string_view>
