commit e9017eec934ba16779d23cc0b0e1ea0568e50d9f
author Edward Lee <edwarddl@google.com> Wed Oct 22 18:00:11 2025 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Oct 22 18:00:49 2025 -0700
tree b2fa9436d0c5c41ce667978493b5a83349111139
parent 7196a2c45fc6c4304deb3818b10417158e487243

Dont Reparse Body in HandleInstallTrustBundle

Duplicate parsing of body here

#tlbmc
#bmc-bloom

PiperOrigin-RevId: 822808500
Change-Id: I46ae989dfa690445d243094f4b852154cd37b318

tlbmc/redfish/routes/certificate_service.cc

diff --git a/tlbmc/redfish/routes/certificate_service.cc b/tlbmc/redfish/routes/certificate_service.cc
index 699da6a..4aa68ef 100644
--- a/tlbmc/redfish/routes/certificate_service.cc
+++ b/tlbmc/redfish/routes/certificate_service.cc
@@ -29,15 +29,8 @@
 
 namespace {
 
-void HandleInstallTrustBundle(const RedfishRequest& req,
+void HandleInstallTrustBundle(const nlohmann::json& body,
                               RedfishResponse& resp) {
-  auto body = nlohmann::json::parse(req.Body(), nullptr, false);
-  if (body.is_discarded()) {
-    resp.SetToAbslStatus(absl::InvalidArgumentError(
-        "The request body is missing or malformed."));
-    return;
-  }
-
   const std::string* cert_type =
       milotic::authz::GetValueAsString(body, "CertificateType");
   if (cert_type == nullptr || *cert_type != "PEM") {
@@ -198,7 +191,7 @@
 
   if (*uri ==
       absl::StrCat(kCertificatesPath, "/", kCertificateNameTrustBundle)) {
-    HandleInstallTrustBundle(req, resp);
+    HandleInstallTrustBundle(body, resp);
   } else if (*uri ==
              absl::StrCat(kCertificatesPath, "/", kCertificateNameServerCert)) {
     HandleInstallServerCert(req, resp);