Google Git
Sign in
gbmc / hothd / 76bb022394b8956f9c9c36cb1830caaa27a0b8e9
commit76bb022394b8956f9c9c36cb1830caaa27a0b8e9[log] [tgz]
authorDavid Tang <davtang@google.com>Wed Nov 13 17:45:24 2024 +0000
committerDavid Tang <davtang@google.com>Wed Nov 13 21:25:11 2024 +0000
tree9cd432b7e1fe6043a4e277eb27ea179732bb9e09
parentae8f3643efff924c49bc0c7679cfe966386229ef [diff]
hothd: Fix message_usb_unittest asan failure

Hitting the following errors when unit tests are invoked with
meson test -C build --print-errorlogs --logbase testlog-ubasan

```
stderr:
../test/message_usb_unittest.cpp:45:11: runtime error: null pointer passed as argument 2, which is declared to never be null
```
Tested:
root@dedb1f56f871:/opt/bmc/onboarding/changes/hothd# meson test -C build --print-errorlogs --logbase testlog-ubasan
ninja: Entering directory `/opt/bmc/onboarding/changes/hothd/build'
[2/2] Linking target test/message_usb_unittest
 1/16 message_file_unittest                 OK              0.15s
 2/16 message_reinit_unittest               OK              0.14s
 3/16 mtd_util_unittest                     OK              0.14s
 4/16 firmware_mtd_updater_unittest         OK              0.16s
 5/16 firmware_spi_updater_unittest         OK              0.15s
 6/16 message_util_unittest                 OK              0.14s
 7/16 payload_update_unittest               OK              0.13s
 8/16 ec_util_unittest                      OK              0.13s
 9/16 log_collector_util_test               OK              0.12s
10/16 payload_update_cli_test               OK              0.02s
11/16 payload_update_parser_test            OK              0.04s
12/16 hoth_state_unittest                   OK              0.14s
13/16 message_usb_unittest                  OK              0.15s
14/16 hoth_updater_cli_test                 OK              2.04s
15/16 hoth_unittest                         OK              2.55s
16/16 host_command_unittest                 OK              6.26s

Ok:                 16
Expected Fail:      0
Fail:               0
Unexpected Pass:    0
Skipped:            0
Timeout:            0

Full log written to /opt/bmc/onboarding/changes/hothd/build/meson-logs/testlog-ubasan.txt

Change-Id: Icaa1fdf60d607ab3ef0d3d10d46b013146d5a4eb
Signed-off-by: David Tang <davtang@google.com>
1 file changed
tree: 9cd432b7e1fe6043a4e277eb27ea179732bb9e09
  1. google3/
  2. subprojects/
  3. test/
  4. tools/
  5. usb_reset/
  6. xyz/
  7. yaml/
  8. 70-hothd-usb.rules
  9. 70-hothd.rules
  10. asset.cpp
  11. asset.hpp
  12. ec_util.cpp
  13. ec_util.hpp
  14. ec_util_interface.hpp
  15. firmware_mtd_updater.cpp
  16. firmware_mtd_updater.hpp
  17. firmware_spi_updater.cpp
  18. firmware_spi_updater.hpp
  19. firmware_updater_interface.hpp
  20. fs.cpp
  21. fs.hpp
  22. host_command.cpp
  23. host_command.hpp
  24. host_command_interface.hpp
  25. hoth.cpp
  26. hoth.hpp
  27. hoth_state.cpp
  28. hoth_state.hpp
  29. hothd-usb@.service.in
  30. hothd.conf
  31. hothd.service.in
  32. hothd_usb.sh.in
  33. libhoth_usb.cpp
  34. libhoth_usb.hpp
  35. libusb.cpp
  36. libusb.hpp
  37. libusb_impl.cpp
  38. libusb_impl.hpp
  39. LICENSE
  40. log_collector_util.cpp
  41. log_collector_util.hpp
  42. main.cpp
  43. MAINTAINERS
  44. meson.build
  45. meson_options.txt
  46. message_file.cpp
  47. message_file.hpp
  48. message_hoth_usb.cpp
  49. message_hoth_usb.hpp
  50. message_intf.hpp
  51. message_reinit.hpp
  52. message_usb.cpp
  53. message_usb.hpp
  54. message_util.cpp
  55. message_util.hpp
  56. mtd_util.cpp
  57. mtd_util.hpp
  58. mtd_util_interface.hpp
  59. payload_update.cpp
  60. payload_update.hpp
  61. payload_update_interface.hpp
  62. README.md
  63. sys.cpp
  64. sys.hpp
  65. sys_interface.hpp
  66. usb_util.cpp
  67. usb_util.hpp
  68. version.cpp
  69. version.hpp
README.md

gbmc-hothd

NOTE: This branch has been scurbbed so it can be upstream or share.