)]}'
{
  "commit": "ab788783037a3592f5f91c867234149d2528b3ca",
  "tree": "33bc38b3ca2dc2408a47eb889a356f39105ea14f",
  "parents": [
    "3df388909541ab189fd667c280c2429d74ef7e7a"
  ],
  "author": {
    "name": "Lovepreet Singh",
    "email": "lpsingh@google.com",
    "time": "Wed Aug 26 03:02:47 2026 -0700"
  },
  "committer": {
    "name": "Lovepreet Singh",
    "email": "lpsingh@google.com",
    "time": "Wed Aug 26 03:16:13 2026 -0700"
  },
  "message": "Handle exceptions from `sendCommand` in `ec_util.cpp`\n\n`sendCommand` in `ec_util.cpp` can throw `CommandRunException`\nexception. This exception is not handled at few places and can cause\n`hothd` to crash.\n\nThis commit makes changes to catch all exceptions in functions which\ninternally call this `sendCommand` method. Since `sendCommand` is a\nprivate method in `EcUtilImpl`, I looked at callers of methods in\n`ec_util.cpp` to find places where exception handling needs to be added.\n\nI added logic to throw `ResponseFailure` in methods that return value\nfor DBus methods in\n`yaml/xyz/openbmc_project/Control/Hoth.interface.yaml` since the YAML\nconfig declares this error\n\nFor `PayloadVersion::version()` method, since this is based on\n`sdbusplus::xyz::openbmc_project::Software::server::Version` interface,\nI added logic to return `SdBusError` exception.\n\nI also removed `EcUtilImpl::getHothPersistentPanicInfo` and updated the\nunit tests since that method does not seem to be used anywhere currently\n\nI tested the change by following steps that crash hothd without this\nchange. With this change, I observed that hothd did not crash after I\nfollowed those steps.\n\nGoogle-Bug-Id: 552303543\nChange-Id: Ic5ba46a56376227b20c92ddebb8e1cc08db52a17\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2c1733e651abd251d8d85c01ba83d64467a3ebb0",
      "old_mode": 33188,
      "old_path": "ec_util.cpp",
      "new_id": "2162cc237a3ad05b6ba8103b60142ffa8c6574a9",
      "new_mode": 33188,
      "new_path": "ec_util.cpp"
    },
    {
      "type": "modify",
      "old_id": "3eee387b18c7cef23dbc9d2874f855f0fd01b520",
      "old_mode": 33188,
      "old_path": "ec_util.hpp",
      "new_id": "6027049ce292eb4d3ab4920bc882d8c56ec5dd1e",
      "new_mode": 33188,
      "new_path": "ec_util.hpp"
    },
    {
      "type": "modify",
      "old_id": "70d4305ec3d8f37123e50a005b23f2af0bc0727f",
      "old_mode": 33188,
      "old_path": "hoth.cpp",
      "new_id": "194a905ad73d764d64d30c670f22bca709783f36",
      "new_mode": 33188,
      "new_path": "hoth.cpp"
    },
    {
      "type": "modify",
      "old_id": "b1d2b0f3ad3ee83ddbbb2050abc56c9428278efb",
      "old_mode": 33188,
      "old_path": "test/ec_util_unittest.cpp",
      "new_id": "69c474d19115bce3b3d10bb1e1f48ffa203c74b2",
      "new_mode": 33188,
      "new_path": "test/ec_util_unittest.cpp"
    },
    {
      "type": "modify",
      "old_id": "4c90eb1aafeac08a601b32aaeb611969fd4a3c0f",
      "old_mode": 33188,
      "old_path": "version.cpp",
      "new_id": "abd893833509c6c93b32ef15bcb13baf98e5550f",
      "new_mode": 33188,
      "new_path": "version.cpp"
    }
  ]
}
