commit 3bc32fd9db47a20f38b0783364fdb2f2f1c97220
author Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Mon Sep 01 12:52:56 2025 +0100
committer Jakub Kicinski <kuba@kernel.org> Wed Sep 03 16:37:42 2025 -0700
tree ce7cf9f077bf0d646c436e8b92198a356de4fa5e
parent 1de95db1242632e121a07f8034273782a5a39656

net: phylink: move PHY interrupt request to non-fail path

The blamed commit added code which could return an error after we
requested the PHY interrupt. When we return an error, the caller
will call phy_detach() which fails to free the interrupt.

Rearrange the code such that failing operations happen before the
interrupt is requested, thereby allowing phy_detach() to be used.

Note that replacing phy_detach() with phy_disconnect() in these
paths could lead to freeing an interrupt which was never requested.

Fixes: 1942b1c6f687 ("net: phylink: make configuring clock-stop dependent on MAC support")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/E1ut35k-00000001UEl-0iq6@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>