)]}' { "commit": "15ab3abf3e718dc1d340ee71c9349f91424476d1", "tree": "2a9958f24862c1200b7d0f928334c73538a7282b", "parents": [ "fc6ba6d90e25d868cefb7a7a56868cd128e1d99d" ], "author": { "name": "Eugene Huang", "email": "eugene.ty.huang@fii-na.corp-partner.google.com", "time": "Thu Jul 23 15:03:57 2026 +0800" }, "committer": { "name": "David Tang", "email": "davtang@google.com", "time": "Mon Aug 31 09:37:44 2026 -0700" }, "message": "phosphor-dump-manager: filter duplicate fault logs\n\n- Filter incoming fault logs based on log ID and timestamp.\n- Skip creating dump entries if a duplicate log is detected.\n- Replace existing dump entry if the incoming log has higher priority.\n- Fault log entry indexes start from 0.\n- Refresh 0004 patch\n\nTested:\n```\nEINJ triggers a fatal error after 10 DRAM CECC injections.\nlocalhost:/opt/AMD/amdraserrorinjectiontest# ./cmdline_amdraserrorinjectiontest --dramecc --address 0x0010000b --enablemcapolling 0 --errortype 0\n...\nlocalhost:/opt/AMD/amdraserrorinjectiontest# ./cmdline_amdraserrorinjectiontest --dferror --errortype 1 --die 0\n\nroot@zoro:~# journalctl -b -u com.amd.RAS@1.service\n...\nJul 01 22:35:33 zoro amd-ras-manager[1837]: The alert signaled is due to a RAS fatal error\n...\nJul 01 22:35:33 zoro amd-ras-manager[1837]: Saving CPER file to /var/lib/amd-bmc-ras/node1-dram-runtime-ras-error0.cper\nJul 01 22:35:33 zoro amd-ras-manager[1837]: Generated runtime CPER file : /var/lib/amd-bmc-ras/node1-dram-runtime-ras-error0.cper\nJul 01 22:35:33 zoro amd-ras-manager[1837]: [HPM0,CPU,ERROR,ASSERT] DRAM CECC runtime error counter overflow occurred\nJul 01 22:35:33 zoro amd-ras-manager[1837]: DRAM CECC runtime error counter overflow occurred\n...\nJul 01 22:35:50 zoro amd-ras-manager[1837]: Saving CPER file to /var/lib/amd-bmc-ras/node1-dram-runtime-ras-error1.cper\nJul 01 22:35:50 zoro amd-ras-manager[1837]: Generated runtime CPER file : /var/lib/amd-bmc-ras/node1-dram-runtime-ras-error1.cper\nJul 01 22:35:50 zoro amd-ras-manager[1837]: [HPM0,CPU,ERROR,ASSERT] DRAM CECC runtime error counter overflow occurred\nJul 01 22:35:50 zoro amd-ras-manager[1837]: DRAM CECC runtime error counter overflow occurred\n...\nJul 01 22:37:14 zoro amd-ras-manager[1837]: Saving CPER file to /var/lib/amd-bmc-ras/node1-dram-runtime-ras-error8.cper\nJul 01 22:37:14 zoro amd-ras-manager[1837]: Generated runtime CPER file : /var/lib/amd-bmc-ras/node1-dram-runtime-ras-error8.cper\nJul 01 22:37:14 zoro amd-ras-manager[1837]: [HPM0,CPU,ERROR,ASSERT] DRAM CECC runtime error counter overflow occurred\nJul 01 22:37:14 zoro amd-ras-manager[1837]: DRAM CECC runtime error counter overflow occurred\n...\nJul 01 22:37:24 zoro amd-ras-manager[1837]: Saving CPER file to /var/lib/amd-bmc-ras/node1-dram-runtime-ras-error9.cper\nJul 01 22:37:24 zoro amd-ras-manager[1837]: Generated runtime CPER file : /var/lib/amd-bmc-ras/node1-dram-runtime-ras-error9.cper\nJul 01 22:37:24 zoro amd-ras-manager[1837]: [HPM0,CPU,ERROR,ASSERT] DRAM CECC runtime error counter overflow occurred\nJul 01 22:37:24 zoro amd-ras-manager[1837]: DRAM CECC runtime error counter overflow occurred\n...\nJul 01 22:38:19 zoro amd-ras-manager[1837]: The alert signaled is due to a RAS fatal error\nJul 01 22:38:19 zoro amd-ras-manager[1837]: RAS FATAL Error detected. System may reset after harvesting MCA data based on policy set.\n...\nJul 01 22:38:20 zoro amd-ras-manager[1837]: Removing CPER: /var/lib/amd-bmc-ras/node1-dram-runtime-ras-error9.cper\nJul 01 22:38:20 zoro amd-ras-manager[1837]: Saving CPER file to /var/lib/amd-bmc-ras/node1-ras-error9.cper\nJul 01 22:38:20 zoro amd-ras-manager[1837]: Generated Fatal CPER file : /var/lib/amd-bmc-ras/node1-ras-error9.cper\n...\n\nroot@zoro:~# busctl tree xyz.openbmc_project.Dump.Manager\n`- /xyz\n `- /xyz/openbmc_project\n `- /xyz/openbmc_project/dump\n |- /xyz/openbmc_project/dump/bmc\n `- /xyz/openbmc_project/dump/faultlog\n |- /xyz/openbmc_project/dump/faultlog/0\n | `- /xyz/openbmc_project/dump/faultlog/0/entry\n | |- /xyz/openbmc_project/dump/faultlog/0/entry/0\n | |- /xyz/openbmc_project/dump/faultlog/0/entry/1\n | |- /xyz/openbmc_project/dump/faultlog/0/entry/2\n | |- /xyz/openbmc_project/dump/faultlog/0/entry/3\n | |- /xyz/openbmc_project/dump/faultlog/0/entry/4\n | |- /xyz/openbmc_project/dump/faultlog/0/entry/5\n | |- /xyz/openbmc_project/dump/faultlog/0/entry/6\n | |- /xyz/openbmc_project/dump/faultlog/0/entry/7\n | |- /xyz/openbmc_project/dump/faultlog/0/entry/8\n | `- /xyz/openbmc_project/dump/faultlog/0/entry/9\n `- /xyz/openbmc_project/dump/faultlog/1\n\nroot@zoro:~# journalctl -b -u xyz.openbmc_project.Dump.Manager.service\nJul 01 22:13:44 zoro systemd[1]: Starting Phosphor Dump Manager...\n...\nJul 01 22:35:33 zoro phosphor-dump-manager[1163]: Got new crashdump notification!\nJul 01 22:35:33 zoro phosphor-dump-manager[1163]: 5:185m5:185m[createDumpFromCrashdumpSignal]: hostId mismatch, dbus signal: 0, hostId: 1\nJul 01 22:35:33 zoro phosphor-dump-manager[1163]: Got new crashdump notification!\nJul 01 22:35:33 zoro phosphor-dump-manager[1163]: In dump_manager_faultlog.cpp createDump\nJul 01 22:35:33 zoro phosphor-dump-manager[1163]: OriginatorId is not provided\nJul 01 22:35:33 zoro phosphor-dump-manager[1163]: OriginatorType is not provided. Replacing the string with the default value\nJul 01 22:35:33 zoro phosphor-dump-manager[1163]: next entry id: 0, entries.size(): 0\nJul 01 22:35:33 zoro phosphor-dump-manager[1163]: dump_manager_faultlog.cpp: add faultlog entry\nJul 01 22:35:33 zoro phosphor-dump-manager[1163]: End of dump_manager_faultlog.cpp createDump\n...\nJul 01 22:37:14 zoro phosphor-dump-manager[1163]: Got new crashdump notification!\nJul 01 22:37:14 zoro phosphor-dump-manager[1163]: 5:185m5:185m[createDumpFromCrashdumpSignal]: hostId mismatch, dbus signal: 0, hostId: 1\nJul 01 22:37:14 zoro phosphor-dump-manager[1163]: Got new crashdump notification!\nJul 01 22:37:14 zoro phosphor-dump-manager[1163]: In dump_manager_faultlog.cpp createDump\nJul 01 22:37:14 zoro phosphor-dump-manager[1163]: OriginatorId is not provided\nJul 01 22:37:14 zoro phosphor-dump-manager[1163]: OriginatorType is not provided. Replacing the string with the default value\nJul 01 22:37:14 zoro phosphor-dump-manager[1163]: next entry id: 8, entries.size(): 8\nJul 01 22:37:14 zoro phosphor-dump-manager[1163]: dump_manager_faultlog.cpp: add faultlog entry\nJul 01 22:37:14 zoro phosphor-dump-manager[1163]: End of dump_manager_faultlog.cpp createDump\nJul 01 22:37:24 zoro phosphor-dump-manager[1163]: Got new crashdump notification!\nJul 01 22:37:24 zoro phosphor-dump-manager[1163]: 5:185m5:185m[createDumpFromCrashdumpSignal]: hostId mismatch, dbus signal: 0, hostId: 1\nJul 01 22:37:24 zoro phosphor-dump-manager[1163]: Got new crashdump notification!\nJul 01 22:37:24 zoro phosphor-dump-manager[1163]: In dump_manager_faultlog.cpp createDump\nJul 01 22:37:24 zoro phosphor-dump-manager[1163]: OriginatorId is not provided\nJul 01 22:37:24 zoro phosphor-dump-manager[1163]: OriginatorType is not provided. Replacing the string with the default value\nJul 01 22:37:24 zoro phosphor-dump-manager[1163]: next entry id: 9, entries.size(): 9\nJul 01 22:37:24 zoro phosphor-dump-manager[1163]: dump_manager_faultlog.cpp: add faultlog entry\nJul 01 22:37:24 zoro phosphor-dump-manager[1163]: End of dump_manager_faultlog.cpp createDump\nJul 01 22:38:20 zoro phosphor-dump-manager[1163]: Got new crashdump notification!\nJul 01 22:38:20 zoro phosphor-dump-manager[1163]: 5:185m5:185m[createDumpFromCrashdumpSignal]: hostId mismatch, dbus signal: 0, hostId: 1\nJul 01 22:38:20 zoro phosphor-dump-manager[1163]: Got new crashdump notification!\nJul 01 22:38:20 zoro phosphor-dump-manager[1163]: In dump_manager_faultlog.cpp createDump\nJul 01 22:38:20 zoro phosphor-dump-manager[1163]: OriginatorId is not provided\nJul 01 22:38:20 zoro phosphor-dump-manager[1163]: OriginatorType is not provided. Replacing the string with the default value\nJul 01 22:38:20 zoro phosphor-dump-manager[1163]: next entry id: 9, entries.size(): 9\nJul 01 22:38:20 zoro phosphor-dump-manager[1163]: dump_manager_faultlog.cpp: add faultlog entry\nJul 01 22:38:20 zoro phosphor-dump-manager[1163]: End of dump_manager_faultlog.cpp createDump\n\nroot@zoro:~# busctl introspect xyz.openbmc_project.Dump.Manager /xyz/openbmc_project/dump/faultlog/0/entry/9\nNAME TYPE SIGNATURE RESULT/VALUE FLAGS\norg.freedesktop.DBus.Introspectable interface - - -\n.Introspect method - s -\norg.freedesktop.DBus.Peer interface - - -\n.GetMachineId method - s -\n.Ping method - - -\norg.freedesktop.DBus.Properties interface - - -\n.Get method ss v -\n.GetAll method s a{sv} -\n.Set method ssv - -\n.PropertiesChanged signal sa{sv}as - -\nxyz.openbmc_project.Common.OriginatedBy interface - - -\n.OriginatorId property s \"\" emits-change writable\n.OriginatorType property s \"xyz.openbmc_project.Common.Originate... emits-change writable\nxyz.openbmc_project.Common.Progress interface - - -\n.CompletedTime property t 1782970699 emits-change writable\n.StartTime property t 1782970699 emits-change writable\n.Status property s \"xyz.openbmc_project.Common.Progress.... emits-change writable\nxyz.openbmc_project.Dump.Entry interface - - -\n.GetFileHandle method - h -\n.InitiateOffload method s - -\n.OffloadUri property s \"\" emits-change writable\n.Offloaded property b false emits-change writable\n.Size property t 55 emits-change writable\nxyz.openbmc_project.Dump.Entry.FaultLog interface - - -\n.AdditionalTypeName property s \"\" const\n.PrimaryLogId property s \"node1-ras-error9.cper\" const\n.Type property s \"xyz.openbmc_project.Common.FaultLogT... const\nxyz.openbmc_project.Object.Delete interface - - -\n.Delete method - - -\nxyz.openbmc_project.Time.EpochTime interface - - -\n.Elapsed property t 1782970699 emits-change writable\n\nroot@zoro:~# busctl get-property xyz.openbmc_project.Dump.Manager /xyz/openbmc_project/dump/faultlog/0/entry/9 xyz.openbmc_project.Dump.Entry.FaultLog Type\ns \"xyz.openbmc_project.Common.FaultLogType.FaultLogTypes.Crashdump\"\n\n```\n\nFusion-Link:\nplatform5: https://fusion2.corp.google.com/47eab8ce-1121-37a6-9495-6aa965e76aba\nplatform15: https://fusion2.corp.google.com/cda5ef0f-d4f6-3ffc-8e22-8d60a70e0ef9\nplatform18: https://fusion2.corp.google.com/5803ed5a-eaa3-30d8-87e7-042d92f1f555\nplatform17: https://fusion2.corp.google.com/ce200d62-7295-3a50-a92d-70cdfdfbf163\nplatform11+ext: https://fusion2.corp.google.com/960816e1-2476-39f0-b0ba-50a1b25b1a50\nplatform11: https://fusion2.corp.google.com/07d2cc8a-1738-35d3-bf9d-6b52f0325873\nPlatforms-Affected: all platforms\nGoogle-Bug-Id: 481913446\nGoogle-Bug-Id: 511865753\nChange-Id: I4d97ac9b333dfd022541a446c58b27a8ba2f2fe3\nSigned-off-by: Eugene Huang \u003ceugene.ty.huang@fii-na.corp-partner.google.com\u003e\nSigned-off-by: cmchang \u003ccmchang@google.com\u003e\n(cherry picked from commit 2089b9e218c57c3b0740b29dc2143066cbb46ed8)\n", "tree_diff": [ { "type": "modify", "old_id": "fba67f41dab5ae9ef8fe7dee975397c5b3f397fe", "old_mode": 33188, "old_path": "recipes-phosphor/dump/phosphor-debug-collector/0003-phosphor-dump-manager-multihost-support.patch", "new_id": "3fea55504f188a443fd79f145a01907fc81f60fd", "new_mode": 33188, "new_path": "recipes-phosphor/dump/phosphor-debug-collector/0003-phosphor-dump-manager-multihost-support.patch" }, { "type": "modify", "old_id": "a8f8b4f1d8f96b47a94e5a55afe7f2147b34903b", "old_mode": 33188, "old_path": "recipes-phosphor/dump/phosphor-debug-collector/0004-add-iliad-cper-signal-handler.patch", "new_id": "872f4c8aebb9b5ac96889472a1bd4456b2504475", "new_mode": 33188, "new_path": "recipes-phosphor/dump/phosphor-debug-collector/0004-add-iliad-cper-signal-handler.patch" }, { "type": "modify", "old_id": "576ed2e0a372e4609ee66fd6165bac2e5f7f8d9a", "old_mode": 33188, "old_path": "recipes-phosphor/dump/phosphor-debug-collector/0005-dump-harden-against-concurrent-file-deletions.patch", "new_id": "b0624ff34630d7b94cb39adc42f1e0301769b45a", "new_mode": 33188, "new_path": "recipes-phosphor/dump/phosphor-debug-collector/0005-dump-harden-against-concurrent-file-deletions.patch" } ] }