)]}'
{
  "commit": "460a5269327b21ce93192d1619fe138caaf6231a",
  "tree": "6de68ff88716a0d196f40c354cb971635bd86ac3",
  "parents": [
    "c2ae4414cc0551d24d0d550d2a230b2667edfd3b"
  ],
  "author": {
    "name": "Willy Tu",
    "email": "wltu@google.com",
    "time": "Fri Jan 31 00:52:15 2025 +0000"
  },
  "committer": {
    "name": "Willy Tu",
    "email": "wltu@google.com",
    "time": "Fri Jan 31 11:25:49 2025 -0800"
  },
  "message": "fix inheritance order of FaultLog\n\nThe destructor order is incorrect which caused the ObjectMapper to not\nsee all the interfaces removed... eventually causing OOM in Object\nMapper. Reorder it to make sure we remove the object in the right order.\n\nhttps://stackoverflow.com/questions/31518581/order-of-destruction-in-the-case-of-multiple-inheritance\n\nThe InterfacesRemoved signal now remove all the interface added, so the\nobject mapper will remove the entry entirely instead of keeping it in\nthe hashmap.\n\n```\nsignal time\u003d1738283381.202322 sender\u003d:1.3856 -\u003e destination\u003d(null destination) serial\u003d466 path\u003d/xyz/openbmc_project/dump; interface\u003dorg.freedesktop.DBus.ObjectManager; member\u003dInterfacesRemoved\n   object path \"/xyz/openbmc_project/dump/faultlog/entry/44\"\n   array [\n      string \"org.freedesktop.DBus.Peer\"\n      string \"org.freedesktop.DBus.Introspectable\"\n      string \"org.freedesktop.DBus.Properties\"\n      string \"xyz.openbmc_project.Dump.Entry.FaultLog\"\n      string \"xyz.openbmc_project.Time.EpochTime\"\n      string \"xyz.openbmc_project.Object.Delete\"\n      string \"xyz.openbmc_project.Dump.Entry\"\n      string \"xyz.openbmc_project.Common.Progress\"\n      string \"xyz.openbmc_project.Common.OriginatedBy\"\n   ]\n```\n\nTested: The logs are still detected by the ObjectMapper properly and\nfound via bmcweb.\n\n```\n$ curl -s http://localhost:80/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries | jq \".Members | length\"\n273\n```\n\nSpamming of CEPR logs and now Object Mapper still does not increase the\nmemory usage significantly. Spammed for 6 hours+.\n\nStart:\n\n```\n$ systemctl status xyz.openbmc_project.ObjectMapper\n● xyz.openbmc_project.ObjectMapper.service - Phosphor DBus Service Discovery Manager\n     Loaded: loaded (/usr/lib/systemd/system/xyz.openbmc_project.ObjectMapper.service; enabled; preset: enabled)\n     Active: active (running) since Fri 2025-01-31 01:08:27 PST; 12s ago\n Invocation: 6e615edea66e4351baa132533d2ccdc0\n   Main PID: 3285 (mapperx)\n     Memory: 4.3M\n        CPU: 2.470s\n     CGroup: /system.slice/xyz.openbmc_project.ObjectMapper.service\n             └─3285 /tmp/mapperx\n```\n\nEnd:\n\n```\n$ systemctl status xyz.openbmc_project.ObjectMapper\n● xyz.openbmc_project.ObjectMapper.service - Phosphor DBus Service Discovery Manager\n     Loaded: loaded (/usr/lib/systemd/system/xyz.openbmc_project.ObjectMapper.service; enabled; preset: enabled)\n     Active: active (running) since Fri 2025-01-31 01:08:27 PST; 6h ago\n Invocation: 6e615edea66e4351baa132533d2ccdc0\n   Main PID: 3285 (mapperx)\n     Memory: 8.1M\n        CPU: 29min 15.200s\n     CGroup: /system.slice/xyz.openbmc_project.ObjectMapper.service\n             └─3285 /tmp/mapperx\n```\n\nFusion-Link: fusion2 link N/A. This change doesn\u0027t affect exiting presubmit tests.\nGoogle-Bug-Id: 393174995\nChange-Id: I731d4421e29672696294f2c9eec99fce2f744c19\nSigned-off-by: Willy Tu \u003cwltu@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fa00ad3f263e64e5fa0f19c109e1ae61759d8852",
      "old_mode": 33188,
      "old_path": "recipes-phosphor/dump/phosphor-debug-collector/0001-Add-CPER-Log-and-Crashdump-support-in-FaultLog.patch",
      "new_id": "c0bed900709a17ce30d48a7da0f27d55f11291e0",
      "new_mode": 33188,
      "new_path": "recipes-phosphor/dump/phosphor-debug-collector/0001-Add-CPER-Log-and-Crashdump-support-in-FaultLog.patch"
    }
  ]
}