)]}'
{
  "commit": "667a2e730e0784a191f5048103b46e8129dd4c92",
  "tree": "e65f283daa4f1d30e0c9561bd2a26894afe9d6af",
  "parents": [
    "7496e04b8b7911263db679e159650f7e034a02e9"
  ],
  "author": {
    "name": "Brian Chiang",
    "email": "chiang.brian@inventec.corp-partner.google.com",
    "time": "Fri Sep 26 10:39:08 2025 +0800"
  },
  "committer": {
    "name": "Munawar Hussain",
    "email": "munawarhussain@google.com",
    "time": "Mon Oct 20 19:45:56 2025 -0700"
  },
  "message": "meta-gbmc-staging: dbus-sensors: gpiosensor: Publish interface after the Present property is set\n\nThe existing code set the Present property false as default and then\nintialize the interface immediately. This causes the interface to be\npublished with Present \u003d false. If actual state of the sensor is\nasserted true, there will be a false negative happening between the time\nthe interface is published and the time the property is updated to true.\n\nIn order to avoid this false negative, move the interface publishing\nafter the Present property is set to the actual state.\n\nTested:\n[Before this change]\nStep 1. dbus-monitor  path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME  interface\u003dxyz.openbmc_project.gpiosensor --system\nStep 2. systemctl restart xyz.openbmc_project.gpiosensor\n\nTest result:\ndbus-monitor  path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME  interface\u003dxyz.openbmc_project.gpiosensor --system\nsignal time\u003d1728627723.100853 sender\u003dorg.freedesktop.DBus -\u003e destination\u003d:1.2898 serial\u003d4294967295 path\u003d/org/freedesktop/DBus; interface\u003dorg.freedesktop.DBus; member\u003dNameAcquired\n   string \":1.2898\"\nsignal time\u003d1728627723.100961 sender\u003dorg.freedesktop.DBus -\u003e destination\u003d:1.2898 serial\u003d4294967295 path\u003d/org/freedesktop/DBus; interface\u003dorg.freedesktop.DBus; member\u003dNameLost\n   string \":1.2898\"\nsignal time\u003d1728627727.461779 sender\u003d:1.2907 -\u003e destination\u003d(null destination) serial\u003d17 path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME; interface\u003dorg.freedesktop.DBus.Properties; member\u003dPropertied\n   string \"xyz.openbmc_project.GPIOStatus\"\n   array [\n      dict entry(\n         string \"Present\"\n         variant             boolean false\n      )\n   ]\n   array [\n   ]\nsignal time\u003d1728627727.461983 sender\u003d:1.2907 -\u003e destination\u003d(null destination) serial\u003d18 path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME; interface\u003dorg.freedesktop.DBus.Properties; member\u003dPropertied\n   string \"xyz.openbmc_project.GPIOStatus\"\n   array [\n      dict entry(\n         string \"Name\"\n         variant             string \"$SENSOR_NAME\"\n      )\n   ]\n   array [\n   ]\nmethod call time\u003d1728627732.623678 sender\u003d:1.81 -\u003e destination\u003dxyz.openbmc_project.GPIOStatus serial\u003d6246 path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME; interface\u003dorg.freedesktop.DBus.Properties;l\n   string \"xyz.openbmc_project.GPIOStatus\"\nsignal time\u003d1728627740.524104 sender\u003d:1.2907 -\u003e destination\u003d(null destination) serial\u003d114 path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME; interface\u003dorg.freedesktop.DBus.Properties; member\u003dPropertid\n   string \"xyz.openbmc_project.GPIOStatus\"\n   array [\n      dict entry(\n         string \"Present\"\n         variant             boolean true\n      )\n   ]\n   array [\n   ]\nmethod call time\u003d1728627745.695646 sender\u003d:1.81 -\u003e destination\u003dxyz.openbmc_project.GPIOStatus serial\u003d6805 path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME; interface\u003dorg.freedesktop.DBus.Properties;l\n   string \"xyz.openbmc_project.GPIOStatus\"\n\n[After this change]\nStep 1. dbus-monitor  path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME  interface\u003dxyz.openbmc_project.gpiosensor --system\nStep 2. systemctl restart xyz.openbmc_project.gpiosensor\n\nTest result:\ndbus-monitor path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME interface\u003dxyz.openbmc_project.gpiosensor --system\nFailed to open connection to session bus: Using X11 for dbus-daemon autolaunch was disabled at compile time, set your DBUS_SESSION_BUS_ADDRESS instead\nroot@cig:~# dbus-monitor  path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME interface\u003dxyz.openbmc_project.gpiosensor --system\nsignal time\u003d1728626779.647020 sender\u003dorg.freedesktop.DBus -\u003e destination\u003d:1.7505 serial\u003d4294967295 path\u003d/org/freedesktop/DBus; interface\u003dorg.freedesktop.DBusd\n   string \":1.7505\"\nsignal time\u003d1728626779.647144 sender\u003dorg.freedesktop.DBus -\u003e destination\u003d:1.7505 serial\u003d4294967295 path\u003d/org/freedesktop/DBus; interface\u003dorg.freedesktop.DBust\n   string \":1.7505\"\nsignal time\u003d1728626812.774611 sender\u003d:1.7544 -\u003e destination\u003d(null destination) serial\u003d62 path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME; interfaced\n   string \"xyz.openbmc_project.GPIOStatus\"\n   array [\n      dict entry(\n         string \"Name\"\n         variant             string \"$SENSOR_NAME\"\n      )\n   ]\n   array [\n   ]\nsignal time\u003d1728626812.775064 sender\u003d:1.7544 -\u003e destination\u003d(null destination) serial\u003d63 path\u003d/xyz/openbmc_project/inventory/item/$SENSOR_NAME; interfaced\n   string \"xyz.openbmc_project.GPIOStatus\"\n   array [\n      dict entry(\n         string \"Present\"\n         variant             boolean true\n      )\n   ]\n   array [\n   ]\nmethod call time\u003d1728626817.932756 sender\u003d:1.136 -\u003e destination\u003dxyz.openbmc_project.GPIOStatus serial\u003d6972 path\u003d/xyz/openbmc_project/inventory/item/BP_12V_CAl\n   string \"xyz.openbmc_project.GPIOStatus\"\n\nFusion-Link:\nplatform11: https://fusion2.corp.google.com/20a5e907-03d3-3e65-94d0-3c33ec0dea0f\nplatform5: https://fusion2.corp.google.com/2e2f42cd-7eb8-3abd-8c47-8cb78e576d5d\nplatform15: https://fusion2.corp.google.com/124f9f34-065c-3311-8c1d-6432f3ecb99f\nplatform17: https://fusion2.corp.google.com/2fef2479-f9ec-3742-8468-56f69b907699\nPlatforms-Affected: All\nGoogle-Bug-Id: 441433977\nChange-Id: Ia3b6e50da077ac45115be1a6e9bdb94b371b08ab\nSigned-off-by: Brian Chiang \u003cchiang.brian@inventec.corp-partner.google.com\u003e\n(cherry picked from commit e1bac3c2109b9f79449616e3c5da0b06a6974932)\n",
  "tree_diff": [
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "02090fbe492e369c8c3331e4287a913300cae010",
      "new_mode": 33188,
      "new_path": "recipes-phosphor/sensors/dbus-sensors/0015-dbus-sensors-gpiosensor-Publish-interface-after-the-.patch"
    },
    {
      "type": "modify",
      "old_id": "39cd80c7552db50e8799f2214be262112df838bc",
      "old_mode": 33188,
      "old_path": "recipes-phosphor/sensors/dbus-sensors_%.bbappend",
      "new_id": "fcc37e44c8c70c2eeaa76b70d174ff5c91819ce9",
      "new_mode": 33188,
      "new_path": "recipes-phosphor/sensors/dbus-sensors_%.bbappend"
    }
  ]
}