ipmitool: fix lan print fails on unsupported parameters
After upgrading to ipmitool 1.8.19, ipmitool lan print can only print
out `Set in Progress` and other parameters are missing on our servers.
After bisecting, commit:
351dad24a2 lan: Add processing of get/set specific CCs
is identified to be the source of the problem, where the function
get_lan_param_select is expected to consider severial error codes it
receives as empty response. It then constructs an empty response in `p`
and assigns `p` to `rc` and the control flow falls through to the
default case, which prints the error code in verbose mode and should
return `rc` instead of `NULL`.
This bug has been fixed in the ipmitool upstream, but OpenBMC has not
yet done a version bump, so we will apply a patch to fix it for now.
Upstream URL:
https://codeberg.org/IPMITool/ipmitool/commit/137aeb64cbb493d61d6945cac156aba5f0510780
Tested:
```
root@:~# ipmitool lan print 1
Set in Progress : Set Complete
Auth Type Support :
Auth Type Enable : Callback :
: User :
: Operator :
: Admin :
: OEM :
IP Address Source : DHCP Address
IP Address : 10.10.11.242
Subnet Mask : 255.255.0.0
MAC Address : e8:d5:2b:12:4c:f8
Default Gateway IP : 10.10.10.204
Default Gateway MAC : 00:00:00:00:00:00
802.1q VLAN ID : Disabled
RMCP+ Cipher Suites : 3,17
Cipher Suite Priv Max : aaaaaaaaaaaaaaa
: X=Cipher Suite Unused
: c=CALLBACK
: u=USER
: o=OPERATOR
: a=ADMIN
: O=OEM
Bad Password Threshold : Not Available
root@:~# echo $?
0
```
Google-Bug-Id: 334000794
Change-Id: I615135b509d3995b8182661bc65a80078c8e2aaf
Signed-off-by: David Wang <davidwang@quanta.corp-partner.google.com>
2 files changed