commit 072a4b7cc013aedd2cf4f9b8477695297a7bd095
author David Tang <davtang@google.com> Thu Oct 24 23:31:52 2024 +0000
committer David Tang <davtang@google.com> Sun Oct 27 16:53:53 2024 +0000
tree f445225bb261df427c5e023b5f1c6d9470ac1fa2
parent a02a4896dc990c594989b80a612e1a7bb2bb9846

[clang-tidy] Resolve clang-tidy errors and format

Resolve the following clang-tidy errors:
readability-avoid-const-params-in-decls
clang-analyzer-security.insecureAPI.bzero

Also run openbmc_build_scripts/scripts/format_code.sh to pass presubmit.

Google-Bug-Id: 375055098
Change-Id: I859f32863972de8cad3a71cf852c6a3e18b02e8b
Signed-off-by: David Tang <davtang@google.com>

README.md

diff --git a/README.md b/README.md
index b5a13f7..235782a 100644
--- a/README.md
+++ b/README.md
@@ -2,16 +2,16 @@
 
 This repo contains:
 
-1. the pldm-oem-google.h, which is the source of truth definitions of
-PLDM google oem elements.
+1. the pldm-oem-google.h, which is the source of truth definitions of PLDM
+   google oem elements.
 
-2. pldmd-oem-google static library, as extension of libpldm, contains
-the helper function to parser the PLDM google oem elements.
+2. pldmd-oem-google static library, as extension of libpldm, contains the helper
+   function to parser the PLDM google oem elements.
 
 ## Google PLDM OEM events
 
-Google defined PLDM OEM events will be sent as PLDM OEM event with `event_class=0xF6`,
-followed by 3 bytes of google IANA `[00 D4 DE]`.
+Google defined PLDM OEM events will be sent as PLDM OEM event with
+`event_class=0xF6`, followed by 3 bytes of google IANA `[00 D4 DE]`.
 
-The specific google OEM event ID and associated oem event data format shall
-be defined in [pldm-oem-google.h](pldm-oem-google.h).
+The specific google OEM event ID and associated oem event data format shall be
+defined in [pldm-oem-google.h](pldm-oem-google.h).

src/soc-reset-me.hpp

diff --git a/src/soc-reset-me.hpp b/src/soc-reset-me.hpp
index c40faae..2e1d64f 100644
--- a/src/soc-reset-me.hpp
+++ b/src/soc-reset-me.hpp
@@ -79,7 +79,7 @@
 class SocResetMeHandler
 {
   public:
-    SocResetMeHandler(const SocId id, sdbusplus::bus_t&& b);
+    SocResetMeHandler(SocId id, sdbusplus::bus_t&& b);
     ~SocResetMeHandler() = default;
     virtual void
         handle(uint8_t requesterTid,
@@ -89,8 +89,8 @@
   protected:
     friend class SocResetMeHandlerTest;
     using ResetTimeStamp = std::chrono::time_point<std::chrono::steady_clock>;
-    virtual void resetSoC(const uint16_t resetType);
-    virtual std::string requestedHostTransition(const uint16_t resetType);
+    virtual void resetSoC(uint16_t resetType);
+    virtual std::string requestedHostTransition(uint16_t resetType);
     virtual void logRequest(uint64_t internalInfo, uint16_t resetType,
                             uint32_t quiescentPeriod,
                             const std::string& resetReason) const;

test/test-soc-reset-me.cpp

diff --git a/test/test-soc-reset-me.cpp b/test/test-soc-reset-me.cpp
index 03b7fd9..e831af8 100644
--- a/test/test-soc-reset-me.cpp
+++ b/test/test-soc-reset-me.cpp
@@ -142,7 +142,7 @@
     {
         std::string_view resetReason{str};
 
-        bzero(&data, sizeof(data));
+        memset(&data, 0, sizeof(data));
         memcpy(data + sizeof(struct pldm_event_oem_google_soc_reset_me),
                resetReason.data(), resetReason.length());
         auto msg =