fw-update: Notify UpdateManager on response decode failure

DeviceUpdater response handlers follow a common pattern: if
response is null, the decoder fails, or the completion code is
non-zero, the device cannot complete the update and the handler
logs an error and returns. The null-response and completion-code
paths correctly notify UpdateManager via updateDeviceCompletion(),
but the decode-failure path silently returns, leaving the software
object in InProgress state indefinitely.

Add updateDeviceCompletion(eid, false) calls to four decode
failure paths so the state machine correctly transitions to
failure:
  - requestUpdate()       (decode_request_update_resp)
  - passCompTable()       (decode_pass_component_table_resp)
  - updateComponent()     (decode_update_component_resp)
  - activateFirmware()    (decode_activate_firmware_resp)

cancelUpdateComponent() is intentionally left unchanged because
it is the cleanup path for an already-failed update.

Reported-by: Vishnunithyasoundhar S (on Gerrit 87785 PS8)
Tested: E2E on Renode evb-ast2600-renode with malformed
UpdateComponent response injection — pldmd correctly logs
decode failure and calls updateDeviceCompletion(eid, false).
Robot test "Should Handle Malformed Update Component Response"
passes. clang-format clean, Docker CI builds cleanly.

Change-Id: Ie04b385abcb86f5fb815cfddb6ec95bca053a19f
Signed-off-by: Gary Beihl <garybeihl@microsoft.com>
1 file changed
tree: 3d4e956441522f087663d26d5b4f265fdd7b05d4
  1. common/
  2. configurations/
  3. docs/
  4. fw-update/
  5. host-bmc/
  6. libpldmresponder/
  7. oem/
  8. platform-mc/
  9. pldmd/
  10. pldmtool/
  11. requester/
  12. softoff/
  13. subprojects/
  14. test/
  15. tools/
  16. utilities/
  17. .clang-format
  18. .clang-tidy
  19. .eslintignore
  20. .gitignore
  21. .linter-ignore
  22. LICENSE
  23. meson.build
  24. meson.options
  25. OWNERS
  26. README.md
README.md

PLDM - Platform Level Data Model

License

Overview

PLDM (Platform Level Data Model) is a key component of the OpenBMC project, providing a standardized data model and message formats for various platform management functionalities. It defines a method to manage, monitor, and control the firmware and hardware of a system.

The OpenBMC PLDM project aims to implement the specifications defined by the Distributed Management Task Force (DMTF), allowing for interoperable management interfaces across different hardware and firmware components.

Features

  • Standardized Messaging: Adheres to the DMTF's PLDM specifications, enabling consistent and interoperable communication between different components.
  • Modularity: Supports multiple PLDM types, including base, FRU,Firmware update, Platform Monitoring and Control, and BIOS Control and Configuration.
  • Extensibility: Easily extendable to support new PLDM types and custom OEM commands.
  • Integration: Seamlessly integrates with other OpenBMC components for comprehensive system management.

Getting Started

Prerequisites

To build and run PLDM, you need the following dependencies:

  • Meson
  • Ninja

Alternatively, source an OpenBMC ARM/x86 SDK.

Building

To build the PLDM project, follow these steps:

meson setup build && meson compile -C build

To run unit tests

The simplest way of running the tests is as described by the meson man page:

meson test -C build

Alternatively, tests can be run in the OpenBMC CI docker container using these steps.

To enable pldm verbosity

pldm daemon accepts a command line argument --verbose or --v or -v to enable the daemon to run in verbose mode. It can be done via adding this option to the environment file that pldm service consumes.

echo 'PLDMD_ARGS="--verbose"' > /etc/default/pldmd
systemctl restart pldmd

To disable pldm verbosity

rm /etc/default/pldmd
systemctl restart pldmd

Documentation

For complete documentation on the functionality and usage of this repository, please refer to the docs folder.