tree b1af0765c82036a1ba12c3771160c688689baf8f
parent a36d51fce28d6cdae168ea0f8b45e4c2fb415b22
author Eric Yang <eric.yang.wiwynn@gmail.com> 1779181199 +0000
committer Eric Yang <eric.yang.wiwynn@gmail.com> 1779250031 +0000

platform-mc: Fix null deref in initTerminus

Commit [1] changed initTerminus() to snapshot TIDs before iterating, but
the loop still looks up each terminus by TID using operator[]. If a
terminus is removed between iterations, operator[] silently inserts a
null entry instead of failing, causing a null pointer dereference on the
next access.

Add a contains() guard before the lookup so that removed TIDs are
skipped, consistent with the existing guards after each co_await.

Tested:
On a Yosemite 4 platform, repeated chassis power cycles trigger the
race. With the fix applied and a temporary log confirming the guard
fires, initTerminus completes without crash.

Reference:
[1] https://gerrit.openbmc.org/c/openbmc/pldm/+/89709

Change-Id: I948d78bfd6087ac2496489752a3291ce5f34eb68
Signed-off-by: Eric Yang <eric.yang.wiwynn@gmail.com>