nvmed: probe features on no ONCS bit 4 and skip empty FeatureStore When ONCS bit 4 is not set (e.g. IronFist controllers) and Log Page 12h is not supported, discoverFeatures previously assumed all standard NVMe features were supported and populated featureCollection without verification. Subsequent Redfish queries (like $expand on /Features) called GetFeature on these unsupported features, causing NVMe-MI command failures (Vendor Specific Status SCT 7 SC 0xf3 on IronFist) and HTTP 500 Internal Error responses. This change actively queries asyncAdminGetFeatures with SEL=CURRENT when ONCS bit 4 is not set to verify feature support before adding to featureCollection. Furthermore, when featureCollection is empty (no features supported by the device), FeatureStore::init returns errc::not_supported and skips registering the D-Bus interface, and controller/subsystem/volume classes log info and reset the featureStore pointer. Tested: Added unit tests and verified with gbmc ci docker nvmed. Google-Bug-Id: 558424309 Change-Id: I50c067e5c73987eb59658530788563e1ac867d0d Signed-off-by: Guangzong Chen <guangzong@google.com> TAG=agy CONV=466d579d-564d-4675-89fd-3d720b796c05
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access
A typical dbus-sensors object support the following dbus interfaces:
Path /xyz/openbmc_project/sensors/<type>/<sensor_name> Interfaces xyz.openbmc_project.Sensor.Value xyz.openbmc_project.Sensor.Threshold.Critical xyz.openbmc_project.Sensor.Threshold.Warning xyz.openbmc_project.State.Decorator.Availability xyz.openbmc_project.State.Decorator.OperationalStatus xyz.openbmc_project.Association.Definitions
Sensor interfaces collection are described in Sensor interfaces.
Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.
dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.
Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.
A simple sensor example can be found in the my_first_sensors example.
Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.