nvme: restore backward compatibility for mi_i2c without bus property

For NVMe devices configured with protocol "mi_i2c" and associated
with MCTP reactor configurations (isMctpReactorDevice), the "Bus"
property is optional because endpoint discovery and routing are
resolved dynamically via MCTP associations.

A recent commit enforced that both "mi_basic" and "mi_i2c" require
the "Bus" property upfront, which caused valid "mi_i2c" reactor
configurations lacking the "Bus" property to be skipped.

This change separates the protocol validation logic so that "mi_i2c"
only enforces the presence of "Bus" when the device is not an MCTP
reactor device, restoring backward compatibility.

Tested:
- Added a temporary unit test simulating NVMe configurations with
  Protocol "mi_i2c" and MctpReactorConfigPath without a "Bus" property,
  verifying that the NVMeSubsystem and NVMeDevice are created.
- Verified that direct "mi_i2c" (without MCTP reactor config) and
  "mi_basic" configurations without "Bus" continue to be rejected.

Google-Bug-Id: 546682451
Change-Id: I6db4c1a47860b6ac1e8ccf5393f3230ba85b8642
Signed-off-by: Hao Jiang <jianghao@google.com>
2 files changed
tree: b337bc01045e914909bf78a19a366e4c24dc4c87
  1. gen/
  2. include/
  3. proto/
  4. service_files/
  5. src/
  6. subprojects/
  7. tests/
  8. yaml/
  9. .clang-format
  10. .clang-tidy
  11. .clang-tidy-ignore
  12. .gitignore
  13. build.md
  14. gemini.md
  15. lesson.md
  16. LICENSE
  17. meson.build
  18. meson_options.txt
  19. OWNERS
  20. README.md
README.md

dbus-sensors

dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.

key features

  • runtime re-configurable from d-bus (entity-manager or the like)

  • isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible

  • async single-threaded: uses sdbusplus/asio bindings

  • multiple data inputs: hwmon, d-bus, direct driver access

dbus interfaces

A typical dbus-sensors object support the following dbus interfaces:

Path        /xyz/openbmc_project/sensors/<type>/<sensor_name>

Interfaces  xyz.openbmc_project.Sensor.Value
            xyz.openbmc_project.Sensor.Threshold.Critical
            xyz.openbmc_project.Sensor.Threshold.Warning
            xyz.openbmc_project.State.Decorator.Availability
            xyz.openbmc_project.State.Decorator.OperationalStatus
            xyz.openbmc_project.Association.Definitions

Sensor interfaces collection are described here.

Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.

Reactor

dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.

Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.

A simple sensor example can be found here.

configuration

Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.

sensor documentation