style: format guidelines and NVMeDevice Format gemini.md and src/NVMeDevice.hpp using prettier and clang-format to satisfy the local Docker linter/formatter check rules. This ensures that subsequent commits in the chain can pass local presubmit verification cleanly. Tested: Verified with local format-code.sh check in Docker. Google-Bug-Id: N/A Change-Id: I9dd070892b67c13d1940af7d66560c9fe7e62384 Signed-off-by: Hao Jiang <jianghao@google.com>
diff --git a/gemini.md b/gemini.md index 14d55db..7a58a98 100644 --- a/gemini.md +++ b/gemini.md
@@ -63,10 +63,14 @@ Before commit, run local presubmit test: -- Create a dummy commit (`git commit -m "temp: strip shmem"`) removing `shared_mem_dep` and `absl_status_dep` in root `meson.build`. -- Copy `common_clang_tidy_config.yaml` from Google3 Kokoro platform configs into the workspace root. -- Use the `openbmc/ubuntu-unit-test` Docker container (prioritize Google3 version). -- Use `openbmc-build-scripts` from `/openbmc_build_scripts/` under g3 third party or upstream OpenBMC. +- Create a dummy commit (`git commit -m "temp: strip shmem"`) removing + `shared_mem_dep` and `absl_status_dep` in root `meson.build`. +- Copy `common_clang_tidy_config.yaml` from Google3 Kokoro platform configs into + the workspace root. +- Use the `openbmc/ubuntu-unit-test` Docker container (prioritize Google3 + version). +- Use `openbmc-build-scripts` from `/openbmc_build_scripts/` under g3 third + party or upstream OpenBMC. - Run `run-unit-test-docker.sh` inside the docker container w/ `-c 1`. - Drop dummy commit w/ `git reset --hard HEAD~1` upon completion.
diff --git a/src/NVMeDevice.hpp b/src/NVMeDevice.hpp index d4a81be..feb40d7 100644 --- a/src/NVMeDevice.hpp +++ b/src/NVMeDevice.hpp
@@ -19,10 +19,11 @@ return std::make_shared<NVMeDevice>(Private(), std::move(intf), subsys); } - static std::shared_ptr<NVMeDevice> create( - boost::asio::io_context& io, const std::shared_ptr<MctpDevice>& dev, - NVMeIntf intf, const std::shared_ptr<NVMeSubsystem>& subsys, - std::chrono::seconds gracePeriod = std::chrono::seconds(5)) + static std::shared_ptr<NVMeDevice> + create(boost::asio::io_context& io, + const std::shared_ptr<MctpDevice>& dev, NVMeIntf intf, + const std::shared_ptr<NVMeSubsystem>& subsys, + std::chrono::seconds gracePeriod = std::chrono::seconds(5)) { return std::make_shared<NVMeDevice>(Private(), io, dev, std::move(intf), subsys, gracePeriod);