Fix 2 ClangTidyLegacy findings:
* annotate this function with 'override' or (rarely) 'final' For more info see go/clang_tidy/checks/modernize-use-override (2 times)
This CL looks good? Just LGTM and Approve it!
This CL doesn’t look good? This is what you can do:
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/clang-tidy-bug for category ClangTidyLegacy if there's an issue with the CL content.
* File a bug under go/rosie-bug if there's an issue with how the CL was managed.
* For all other issues such as the formatting of the CL, please file a bug under
go/clrobot-bug.
* Revert this CL and not get a CL that cleans up these paths in the future by
replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.
This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/production/sushid/safepower_agent/METADATA by
following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug
at go/clrobot-bug.
#codehealth
Tested:
Local presubmit tests passed.
PiperOrigin-RevId: 709962644
Change-Id: Id247eac2ef2fa9de995b729420a319f33c4571cc
diff --git a/bmc/persistent_storage_bmc.h b/bmc/persistent_storage_bmc.h
index 9972143..e689ea9 100644
--- a/bmc/persistent_storage_bmc.h
+++ b/bmc/persistent_storage_bmc.h
@@ -21,7 +21,7 @@
struct PersistentStorageManagerBMC
: public safepower_agent::PersistentStorageManager {
public:
- ~PersistentStorageManagerBMC() = default;
+ ~PersistentStorageManagerBMC() override = default;
// Writes a delta to the saved actions to persistent storage.
absl::Status WriteSavedActionsChange(
diff --git a/bmc/scheduler_bmc.h b/bmc/scheduler_bmc.h
index ad2a171..b3b348c 100644
--- a/bmc/scheduler_bmc.h
+++ b/bmc/scheduler_bmc.h
@@ -33,7 +33,7 @@
SchedulerBMC() = delete;
explicit SchedulerBMC(
boost::asio::io_context& io_in ABSL_ATTRIBUTE_LIFETIME_BOUND);
- ~SchedulerBMC();
+ ~SchedulerBMC() override;
absl::Status PeriodicCall(absl::AnyInvocable<void()> fn,
absl::Duration interval,