Google Git
Sign in
gbmc / hothd / 7298ddee0a74d50296aeb48ae9f79049b51b57b6
commit7298ddee0a74d50296aeb48ae9f79049b51b57b6[log] [tgz]
authorKonda Reddy Kachana <kkachana@google.com>Wed Jan 08 21:04:42 2025 +0000
committerKonda Reddy Kachana <kkachana@google.com>Wed Jan 08 21:25:47 2025 +0000
treeeaff5906e64cf8f9a29344f65c8f4e4cbcdd4883
parent08c451f5a5b5ba8d0c873a03e167a0eabf79bab5 [diff]
hothd: Fix payload_update crash on error

Avoid payload_upload tool crash on underlying errors
by graceful exit.

Tested:
root@uycyv5-nfd01:~# coredumpctl
No coredumps found.

root@uycyv5-nfd01:~# payload_update -i ***_ioc_4_3 update /tmp/d1_injected_sas4024fw.img  -r -m 1
Failed to get SPS passthrough status: sd_bus_call: org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable
Target did not report SPS passthrough disabled. Attempting reset
***_ioc_4_3: Put target in reset
terminate called after throwing an instance of 'sdbusplus::exception::SdBusError'
  what():  sd_bus_call: org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable
Aborted (core dumped)

root@uycyv5-nfd01:~# coredumpctl
TIME                         PID UID GID SIG     COREFILE EXE                      SIZE
Wed 2025-01-08 13:11:29 PST 5572   0   0 SIGABRT present  /usr/bin/payload_update 64.7K

root@uycyv5-nfd01:~# /tmp/payload_update -i ***_ioc_4_3 update /tmp/d1_injected_sas4024fw.img  -r -m 1
Failed to get SPS passthrough status: sd_bus_call: org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable
Target did not report SPS passthrough disabled. Attempting reset
***_ioc_4_3: Put target in reset
Failed to execute command: sd_bus_call: org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable

root@uycyv5-nfd01:~# coredumpctl
TIME                         PID UID GID SIG     COREFILE EXE                      SIZE
Wed 2025-01-08 13:11:29 PST 5572   0   0 SIGABRT present  /usr/bin/payload_update 64.7K
root@uycyv5-nfd01:~#

Google-Bug-Id: 361460251
Change-Id: Ifab3ffadc8fcb318f9abd4bafd457e4cf4c95e98
Signed-off-by: Konda Reddy Kachana <kkachana@google.com>
1 file changed
tree: eaff5906e64cf8f9a29344f65c8f4e4cbcdd4883
  1. google3/
  2. subprojects/
  3. test/
  4. tools/
  5. usb_reset/
  6. xyz/
  7. yaml/
  8. .clang-tidy
  9. .clang-tidy-ignore
  10. 70-hothd-usb.rules
  11. 70-hothd.rules
  12. activation.hpp
  13. asset.cpp
  14. asset.hpp
  15. ec_util.cpp
  16. ec_util.hpp
  17. ec_util_interface.hpp
  18. firmware_mtd_updater.cpp
  19. firmware_mtd_updater.hpp
  20. firmware_spi_updater.cpp
  21. firmware_spi_updater.hpp
  22. firmware_updater_interface.hpp
  23. fs.cpp
  24. fs.hpp
  25. host_command.cpp
  26. host_command.hpp
  27. host_command_interface.hpp
  28. hoth.cpp
  29. hoth.hpp
  30. hoth_state.cpp
  31. hoth_state.hpp
  32. hothd-usb@.service.in
  33. hothd.conf
  34. hothd.service.in
  35. hothd_usb.sh.in
  36. libhoth_usb.cpp
  37. libhoth_usb.hpp
  38. libusb.cpp
  39. libusb.hpp
  40. libusb_impl.cpp
  41. libusb_impl.hpp
  42. LICENSE
  43. log_collector_util.cpp
  44. log_collector_util.hpp
  45. main.cpp
  46. MAINTAINERS
  47. meson.build
  48. meson_options.txt
  49. message_file.cpp
  50. message_file.hpp
  51. message_hoth_usb.cpp
  52. message_hoth_usb.hpp
  53. message_intf.hpp
  54. message_reinit.hpp
  55. message_usb.cpp
  56. message_usb.hpp
  57. message_util.cpp
  58. message_util.hpp
  59. mtd_util.cpp
  60. mtd_util.hpp
  61. mtd_util_interface.hpp
  62. payload_update.cpp
  63. payload_update.hpp
  64. payload_update_interface.hpp
  65. README.md
  66. sys.cpp
  67. sys.hpp
  68. sys_interface.hpp
  69. usb_util.cpp
  70. usb_util.hpp
  71. version.cpp
  72. version.hpp
README.md

gbmc-hothd

NOTE: This branch has been scurbbed so it can be upstream or share.