Migrate to encode_pldm_base_get_tid_resp() Migrate the codes that use encode_get_tid_resp() to using the newly added encode_pldm_base_get_tid_resp() API as a replacement. Change-Id: Ie7e48ec36e9d96504d8088dfc8c756311e48beae Signed-off-by: Chau Ly <chaul@amperecomputing.com>
diff --git a/libpldmresponder/base.cpp b/libpldmresponder/base.cpp index e2458aa..2152c99 100644 --- a/libpldmresponder/base.cpp +++ b/libpldmresponder/base.cpp
@@ -178,13 +178,15 @@ Response Handler::getTID(const pldm_msg* request, size_t /*payloadLength*/) { - Response response(sizeof(pldm_msg_hdr) + PLDM_GET_TID_RESP_BYTES, 0); + pldm_base_get_tid_resp resp{PLDM_SUCCESS, TERMINUS_ID}; + Response response(sizeof(pldm_msg_hdr) + PLDM_BASE_GET_TID_RESP_BYTES, 0); auto responsePtr = new (response.data()) pldm_msg; - auto rc = encode_get_tid_resp(request->hdr.instance_id, PLDM_SUCCESS, - TERMINUS_ID, responsePtr); - if (rc != PLDM_SUCCESS) + size_t payloadLength = PLDM_BASE_GET_TID_RESP_BYTES; + auto rc = encode_pldm_base_get_tid_resp(request->hdr.instance_id, &resp, + responsePtr, &payloadLength); + if (rc || payloadLength != PLDM_BASE_GET_TID_RESP_BYTES) { - return ccOnlyResponse(request, rc); + return ccOnlyResponse(request, PLDM_ERROR); } if (oemPlatformHandler)
diff --git a/platform-mc/test/terminus_manager_test.cpp b/platform-mc/test/terminus_manager_test.cpp index a170bd1..9bee4b9 100644 --- a/platform-mc/test/terminus_manager_test.cpp +++ b/platform-mc/test/terminus_manager_test.cpp
@@ -130,7 +130,7 @@ TEST_F(TerminusManagerTest, discoverMctpTerminusTest) { - const size_t getTidRespLen = PLDM_GET_TID_RESP_BYTES; + const size_t getTidRespLen = PLDM_BASE_GET_TID_RESP_BYTES; const size_t setTidRespLen = PLDM_SET_TID_RESP_BYTES; const size_t getPldmTypesRespLen = PLDM_BASE_GET_PLDM_TYPES_RESP_BYTES; @@ -189,7 +189,7 @@ TEST_F(TerminusManagerTest, negativeDiscoverMctpTerminusTest) { - const size_t getTidRespLen = PLDM_GET_TID_RESP_BYTES; + const size_t getTidRespLen = PLDM_BASE_GET_TID_RESP_BYTES; const size_t setTidRespLen = PLDM_SET_TID_RESP_BYTES; const size_t getPldmTypesRespLen = PLDM_BASE_GET_PLDM_TYPES_RESP_BYTES; @@ -245,7 +245,7 @@ TEST_F(TerminusManagerTest, doesSupportTypeTest) { - const size_t getTidRespLen = PLDM_GET_TID_RESP_BYTES; + const size_t getTidRespLen = PLDM_BASE_GET_TID_RESP_BYTES; const size_t setTidRespLen = PLDM_SET_TID_RESP_BYTES; const size_t getPldmTypesRespLen = PLDM_BASE_GET_PLDM_TYPES_RESP_BYTES; @@ -295,7 +295,7 @@ TEST_F(TerminusManagerTest, doesSupportCommandTest) { - const size_t getTidRespLen = PLDM_GET_TID_RESP_BYTES; + const size_t getTidRespLen = PLDM_BASE_GET_TID_RESP_BYTES; const size_t setTidRespLen = PLDM_SET_TID_RESP_BYTES; const size_t getPldmTypesRespLen = PLDM_BASE_GET_PLDM_TYPES_RESP_BYTES; const size_t getPldmCommandRespLen = PLDM_GET_COMMANDS_RESP_BYTES;
diff --git a/requester/test/handler_test.cpp b/requester/test/handler_test.cpp index cbc9ccc..0450065 100644 --- a/requester/test/handler_test.cpp +++ b/requester/test/handler_test.cpp
@@ -305,12 +305,17 @@ }), exec::default_task_context<void>(stdexec::inline_scheduler{})); - pldm::Response mockResponse(sizeof(pldm_msg_hdr) + PLDM_GET_TID_RESP_BYTES, - 0); + pldm::Response mockResponse( + sizeof(pldm_msg_hdr) + PLDM_BASE_GET_TID_RESP_BYTES, 0); auto mockResponseMsg = new (mockResponse.data()) pldm_msg; // Compose response message of getTID command - encode_get_tid_resp(instanceId, PLDM_SUCCESS, expectedTid, mockResponseMsg); + pldm_base_get_tid_resp resp{PLDM_SUCCESS, expectedTid}; + size_t payloadLength = PLDM_BASE_GET_TID_RESP_BYTES; + auto rc = encode_pldm_base_get_tid_resp(instanceId, &resp, mockResponseMsg, + &payloadLength); + EXPECT_EQ(rc, PLDM_SUCCESS); + EXPECT_EQ(payloadLength, PLDM_BASE_GET_TID_RESP_BYTES); // Send response back to resume getTID coroutine to update respTid by // calling reqHandler.handleResponse() manually