Google GitGoogle Git
Sign in
gbmc/pldm/b04aad1a7af957f703addde2d53b8dff7531ef79
commit
b04aad1a7af957f703addde2d53b8dff7531ef79
[log]
author
Eric Yang <eric.yang.wiwynn@gmail.com>
Tue May 19 08:59:59 2026 +0000
committer
Eric Yang <eric.yang.wiwynn@gmail.com>
Wed May 20 04:07:11 2026 +0000
tree
b1af0765c82036a1ba12c3771160c688689baf8f
parent
a36d51fce28d6cdae168ea0f8b45e4c2fb415b22 [diff]
platform-mc: Fix null deref in initTerminus

Commit [1] changed initTerminus() to snapshot TIDs before iterating, but
the loop still looks up each terminus by TID using operator[]. If a
terminus is removed between iterations, operator[] silently inserts a
null entry instead of failing, causing a null pointer dereference on the
next access.

Add a contains() guard before the lookup so that removed TIDs are
skipped, consistent with the existing guards after each co_await.

Tested:
On a Yosemite 4 platform, repeated chassis power cycles trigger the
race. With the fix applied and a temporary log confirming the guard
fires, initTerminus completes without crash.

Reference:
[1] https://gerrit.openbmc.org/c/openbmc/pldm/+/89709

Change-Id: I948d78bfd6087ac2496489752a3291ce5f34eb68
Signed-off-by: Eric Yang <eric.yang.wiwynn@gmail.com>
1 file changed
tree: b1af0765c82036a1ba12c3771160c688689baf8f
  1. common/
  2. configurations/
  3. docs/
  4. fw-update/
  5. host-bmc/
  6. libpldmresponder/
  7. oem/
  8. platform-mc/
  9. pldmd/
  10. pldmtool/
  11. requester/
  12. softoff/
  13. subprojects/
  14. test/
  15. tools/
  16. utilities/
  17. .clang-format
  18. .clang-tidy
  19. .eslintignore
  20. .gitignore
  21. .linter-ignore
  22. LICENSE
  23. meson.build
  24. meson.options
  25. OWNERS
  26. README.md
README.md

PLDM - Platform Level Data Model

License

Overview

PLDM (Platform Level Data Model) is a key component of the OpenBMC project, providing a standardized data model and message formats for various platform management functionalities. It defines a method to manage, monitor, and control the firmware and hardware of a system.

The OpenBMC PLDM project aims to implement the specifications defined by the Distributed Management Task Force (DMTF), allowing for interoperable management interfaces across different hardware and firmware components.

Features

  • Standardized Messaging: Adheres to the DMTF's PLDM specifications, enabling consistent and interoperable communication between different components.
  • Modularity: Supports multiple PLDM types, including base, FRU,Firmware update, Platform Monitoring and Control, and BIOS Control and Configuration.
  • Extensibility: Easily extendable to support new PLDM types and custom OEM commands.
  • Integration: Seamlessly integrates with other OpenBMC components for comprehensive system management.

Getting Started

Prerequisites

To build and run PLDM, you need the following dependencies:

  • Meson
  • Ninja

Alternatively, source an OpenBMC ARM/x86 SDK.

Building

To build the PLDM project, follow these steps:

meson setup build && meson compile -C build

To run unit tests

The simplest way of running the tests is as described by the meson man page:

meson test -C build

Alternatively, tests can be run in the OpenBMC CI docker container using these steps.

To enable pldm verbosity

pldm daemon accepts a command line argument --verbose or --v or -v to enable the daemon to run in verbose mode. It can be done via adding this option to the environment file that pldm service consumes.

echo 'PLDMD_ARGS="--verbose"' > /etc/default/pldmd
systemctl restart pldmd

To disable pldm verbosity

rm /etc/default/pldmd
systemctl restart pldmd

Documentation

For complete documentation on the functionality and usage of this repository, please refer to the docs folder.