fix modernize-use-override This is a clang-tidy check, but modernize-use-override is not added to the configuration as it does not yet exist in the reference tidy configuration. Tested: Ran unit tests. Change-Id: I9f8015ffaba52cb1376ba7aa48914cd1ff2b80f8 Signed-off-by: Brad Bishop <bradbish@qti.qualcomm.com>
diff --git a/fw-update/manager.hpp b/fw-update/manager.hpp index 1ff5e64..924f4fc 100644 --- a/fw-update/manager.hpp +++ b/fw-update/manager.hpp
@@ -26,7 +26,7 @@ Manager(Manager&&) = delete; Manager& operator=(const Manager&) = delete; Manager& operator=(Manager&&) = delete; - ~Manager() = default; + ~Manager() override = default; /** * @brief Constructor for the PLDM Firmware Update Manager
diff --git a/fw-update/package_parser.hpp b/fw-update/package_parser.hpp index 4348a80..396a05f 100644 --- a/fw-update/package_parser.hpp +++ b/fw-update/package_parser.hpp
@@ -151,7 +151,7 @@ PackageParserV1(PackageParserV1&&) = default; PackageParserV1& operator=(const PackageParserV1&) = delete; PackageParserV1& operator=(PackageParserV1&&) = delete; - ~PackageParserV1() = default; + ~PackageParserV1() override = default; /** @brief Constructor * @@ -168,7 +168,7 @@ PackageParser(pkgHeaderSize, pkgVersion, componentBitmapBitLength) {} - virtual void parse(const std::vector<uint8_t>& pkgHdr, uintmax_t pkgSize); + void parse(const std::vector<uint8_t>& pkgHdr, uintmax_t pkgSize) override; }; /** @brief Parse the package header information
diff --git a/fw-update/update.hpp b/fw-update/update.hpp index 5cefdcc..ae51dc7 100644 --- a/fw-update/update.hpp +++ b/fw-update/update.hpp
@@ -38,7 +38,7 @@ objPath(path) {} - virtual sdbusplus::object_path startUpdate( + sdbusplus::object_path startUpdate( sdbusplus::message::unix_fd image, ApplyTimeIntf::RequestedApplyTimes applyTime) override;
diff --git a/host-bmc/dbus/asset.hpp b/host-bmc/dbus/asset.hpp index e1188d7..e594ea2 100644 --- a/host-bmc/dbus/asset.hpp +++ b/host-bmc/dbus/asset.hpp
@@ -19,7 +19,7 @@ { public: Asset() = delete; - ~Asset() = default; + ~Asset() override = default; Asset(const Asset&) = delete; Asset& operator=(const Asset&) = delete; Asset(Asset&&) = delete;
diff --git a/host-bmc/dbus/availability.hpp b/host-bmc/dbus/availability.hpp index 5788f70..1b0b410 100644 --- a/host-bmc/dbus/availability.hpp +++ b/host-bmc/dbus/availability.hpp
@@ -18,7 +18,7 @@ { public: Availability() = delete; - ~Availability() = default; + ~Availability() override = default; Availability(const Availability&) = delete; Availability& operator=(const Availability&) = delete; Availability(Availability&&) = delete;
diff --git a/host-bmc/dbus/board.hpp b/host-bmc/dbus/board.hpp index a9cfde5..059f517 100644 --- a/host-bmc/dbus/board.hpp +++ b/host-bmc/dbus/board.hpp
@@ -18,7 +18,7 @@ { public: Board() = delete; - ~Board() = default; + ~Board() override = default; Board(const Board&) = delete; Board& operator=(const Board&) = delete; Board(Board&&) = delete;
diff --git a/host-bmc/dbus/cable.hpp b/host-bmc/dbus/cable.hpp index d68c0be..a27d363 100644 --- a/host-bmc/dbus/cable.hpp +++ b/host-bmc/dbus/cable.hpp
@@ -23,7 +23,7 @@ { public: Cable() = delete; - ~Cable() = default; + ~Cable() override = default; Cable(const Cable&) = delete; Cable& operator=(const Cable&) = delete;
diff --git a/host-bmc/dbus/chassis.hpp b/host-bmc/dbus/chassis.hpp index 55997df..d13e69f 100644 --- a/host-bmc/dbus/chassis.hpp +++ b/host-bmc/dbus/chassis.hpp
@@ -18,7 +18,7 @@ { public: ItemChassis() = delete; - ~ItemChassis() = default; + ~ItemChassis() override = default; ItemChassis(const ItemChassis&) = delete; ItemChassis& operator=(const ItemChassis&) = delete; ItemChassis(ItemChassis&&) = delete;
diff --git a/host-bmc/dbus/connector.hpp b/host-bmc/dbus/connector.hpp index cb0128e..95c8c67 100644 --- a/host-bmc/dbus/connector.hpp +++ b/host-bmc/dbus/connector.hpp
@@ -18,7 +18,7 @@ { public: Connector() = delete; - ~Connector() = default; + ~Connector() override = default; Connector(const Connector&) = delete; Connector& operator=(const Connector&) = delete; Connector(Connector&&) = delete;
diff --git a/host-bmc/dbus/cpu_core.hpp b/host-bmc/dbus/cpu_core.hpp index 134a545..d2dcb11 100644 --- a/host-bmc/dbus/cpu_core.hpp +++ b/host-bmc/dbus/cpu_core.hpp
@@ -18,7 +18,7 @@ { public: CPUCore() = delete; - ~CPUCore() = default; + ~CPUCore() override = default; CPUCore(const CPUCore&) = delete; CPUCore& operator=(const CPUCore&) = delete; CPUCore(CPUCore&&) = delete;
diff --git a/host-bmc/dbus/fabric_adapter.hpp b/host-bmc/dbus/fabric_adapter.hpp index bc2e5c1..4ca2279 100644 --- a/host-bmc/dbus/fabric_adapter.hpp +++ b/host-bmc/dbus/fabric_adapter.hpp
@@ -18,7 +18,7 @@ { public: FabricAdapter() = delete; - ~FabricAdapter() = default; + ~FabricAdapter() override = default; FabricAdapter(const FabricAdapter&) = delete; FabricAdapter& operator=(const FabricAdapter&) = delete; FabricAdapter(FabricAdapter&&) = delete;
diff --git a/host-bmc/dbus/fan.hpp b/host-bmc/dbus/fan.hpp index 61a995d..73d2d20 100644 --- a/host-bmc/dbus/fan.hpp +++ b/host-bmc/dbus/fan.hpp
@@ -18,7 +18,7 @@ { public: Fan() = delete; - ~Fan() = default; + ~Fan() override = default; Fan(const Fan&) = delete; Fan& operator=(const Fan&) = delete; Fan(Fan&&) = delete;
diff --git a/host-bmc/dbus/inventory_item.hpp b/host-bmc/dbus/inventory_item.hpp index 17699ee..88f5de8 100644 --- a/host-bmc/dbus/inventory_item.hpp +++ b/host-bmc/dbus/inventory_item.hpp
@@ -18,7 +18,7 @@ { public: InventoryItem() = delete; - ~InventoryItem() = default; + ~InventoryItem() override = default; InventoryItem(const InventoryItem&) = delete; InventoryItem& operator=(const InventoryItem&) = delete; InventoryItem(InventoryItem&&) = delete;
diff --git a/host-bmc/dbus/motherboard.hpp b/host-bmc/dbus/motherboard.hpp index bf62036..fc2acd1 100644 --- a/host-bmc/dbus/motherboard.hpp +++ b/host-bmc/dbus/motherboard.hpp
@@ -23,7 +23,7 @@ { public: Motherboard() = delete; - ~Motherboard() = default; + ~Motherboard() override = default; Motherboard(const Motherboard&) = delete; Motherboard& operator=(const Motherboard&) = delete; Motherboard(Motherboard&&) = delete;
diff --git a/host-bmc/dbus/panel.hpp b/host-bmc/dbus/panel.hpp index 2f91250..ae9c277 100644 --- a/host-bmc/dbus/panel.hpp +++ b/host-bmc/dbus/panel.hpp
@@ -18,7 +18,7 @@ { public: Panel() = delete; - ~Panel() = default; + ~Panel() override = default; Panel(const Panel&) = delete; Panel& operator=(const Panel&) = delete; Panel(Panel&&) = delete;
diff --git a/host-bmc/dbus/pcie_device.hpp b/host-bmc/dbus/pcie_device.hpp index 036e078..254c517 100644 --- a/host-bmc/dbus/pcie_device.hpp +++ b/host-bmc/dbus/pcie_device.hpp
@@ -26,7 +26,7 @@ { public: PCIeDevice() = delete; - ~PCIeDevice() = default; + ~PCIeDevice() override = default; PCIeDevice(const PCIeDevice&) = delete; PCIeDevice& operator=(const PCIeDevice&) = delete;
diff --git a/host-bmc/dbus/pcie_slot.hpp b/host-bmc/dbus/pcie_slot.hpp index 1acea80..a60cb1a 100644 --- a/host-bmc/dbus/pcie_slot.hpp +++ b/host-bmc/dbus/pcie_slot.hpp
@@ -22,7 +22,7 @@ { public: PCIeSlot() = delete; - ~PCIeSlot() = default; + ~PCIeSlot() override = default; PCIeSlot(const PCIeSlot&) = delete; PCIeSlot& operator=(const PCIeSlot&) = delete;
diff --git a/host-bmc/dbus/power_supply.hpp b/host-bmc/dbus/power_supply.hpp index 40e26e3..b809191 100644 --- a/host-bmc/dbus/power_supply.hpp +++ b/host-bmc/dbus/power_supply.hpp
@@ -18,7 +18,7 @@ { public: PowerSupply() = delete; - ~PowerSupply() = default; + ~PowerSupply() override = default; PowerSupply(const PowerSupply&) = delete; PowerSupply& operator=(const PowerSupply&) = delete; PowerSupply(PowerSupply&&) = delete;
diff --git a/host-bmc/dbus/vrm.hpp b/host-bmc/dbus/vrm.hpp index c38bbf8..5d0dcfe 100644 --- a/host-bmc/dbus/vrm.hpp +++ b/host-bmc/dbus/vrm.hpp
@@ -18,7 +18,7 @@ { public: VRM() = delete; - ~VRM() = default; + ~VRM() override = default; VRM(const VRM&) = delete; VRM& operator=(const VRM&) = delete; VRM(VRM&&) = delete;
diff --git a/host-bmc/host_condition.hpp b/host-bmc/host_condition.hpp index ad5a862..91d2967 100644 --- a/host-bmc/host_condition.hpp +++ b/host-bmc/host_condition.hpp
@@ -22,7 +22,7 @@ Host& operator=(const Host&) = delete; Host(Host&&) = delete; Host& operator=(Host&&) = delete; - virtual ~Host() = default; + ~Host() override = default; Host(sdbusplus::bus_t& bus, const std::string& path) : HostIntf(bus, path.c_str()) {};
diff --git a/libpldmresponder/oem_handler.hpp b/libpldmresponder/oem_handler.hpp index fc91289..300d5b9 100644 --- a/libpldmresponder/oem_handler.hpp +++ b/libpldmresponder/oem_handler.hpp
@@ -132,7 +132,7 @@ /** @brief To handle the boot types bios attributes at shutdown*/ virtual void handleBootTypesAtChassisOff() = 0; - virtual ~Handler() = default; + ~Handler() override = default; protected: const pldm::utils::DBusHandler* dBusIntf; @@ -156,7 +156,7 @@ */ virtual int processOEMFRUTable(const std::vector<uint8_t>& fruData) = 0; - virtual ~Handler() = default; + ~Handler() override = default; }; } // namespace oem_fru @@ -181,7 +181,7 @@ virtual int setCoreCount(const EntityAssociations& associations, const EntityMaps entityMaps) = 0; - virtual ~Handler() = default; + ~Handler() override = default; protected: const pldm::utils::DBusHandler* dBusIntf; @@ -202,7 +202,7 @@ virtual void processOEMBaseBiosTable( const pldm::bios::BaseBIOSTable& biosTable) = 0; - virtual ~Handler() = default; + ~Handler() override = default; }; } // namespace oem_bios
diff --git a/oem/ibm/host-bmc/host_lamp_test.hpp b/oem/ibm/host-bmc/host_lamp_test.hpp index 2581557..e18320b 100644 --- a/oem/ibm/host-bmc/host_lamp_test.hpp +++ b/oem/ibm/host-bmc/host_lamp_test.hpp
@@ -31,7 +31,7 @@ { public: HostLampTest() = delete; - ~HostLampTest() = default; + ~HostLampTest() override = default; HostLampTest(const HostLampTest&) = delete; HostLampTest& operator=(const HostLampTest&) = delete; HostLampTest(HostLampTest&&) = delete;
diff --git a/oem/ibm/libpldmresponder/file_io_type_cert.hpp b/oem/ibm/libpldmresponder/file_io_type_cert.hpp index 8613cd5..e17f90c 100644 --- a/oem/ibm/libpldmresponder/file_io_type_cert.hpp +++ b/oem/ibm/libpldmresponder/file_io_type_cert.hpp
@@ -28,37 +28,35 @@ FileHandler(fileHandle), certType(fileType) {} - virtual int writeFromMemory(uint32_t offset, uint32_t length, - uint64_t address, - oem_platform::Handler* /*oemPlatformHandler*/); - virtual int readIntoMemory(uint32_t offset, uint32_t length, - uint64_t address, - oem_platform::Handler* /*oemPlatformHandler*/); - virtual int read(uint32_t offset, uint32_t& length, Response& response, - oem_platform::Handler* /*oemPlatformHandler*/); + int writeFromMemory(uint32_t offset, uint32_t length, uint64_t address, + oem_platform::Handler* /*oemPlatformHandler*/) override; + int readIntoMemory(uint32_t offset, uint32_t length, uint64_t address, + oem_platform::Handler* /*oemPlatformHandler*/) override; + int read(uint32_t offset, uint32_t& length, Response& response, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int write(const char* buffer, uint32_t offset, uint32_t& length, - oem_platform::Handler* /*oemPlatformHandler*/); + int write(const char* buffer, uint32_t offset, uint32_t& length, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int fileAck(uint8_t /*fileStatus*/) + int fileAck(uint8_t /*fileStatus*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int newFileAvailable(uint64_t length); + int newFileAvailable(uint64_t length) override; - virtual int fileAckWithMetaData( - uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, - uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/); + int fileAckWithMetaData(uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, + uint32_t /*metaDataValue2*/, + uint32_t /*metaDataValue3*/, + uint32_t /*metaDataValue4*/) override; - virtual int newFileAvailableWithMetaData( + int newFileAvailableWithMetaData( uint64_t length, uint32_t metaDataValue1, uint32_t /*metaDataValue2*/, - uint32_t /*metaDataValue3*/, uint32_t /*metaDataValue4*/); + uint32_t /*metaDataValue3*/, uint32_t /*metaDataValue4*/) override; /** @brief CertHandler destructor */ - ~CertHandler() {} + ~CertHandler() override {} private: uint16_t certType; //!< type of the certificate
diff --git a/oem/ibm/libpldmresponder/file_io_type_dump.hpp b/oem/ibm/libpldmresponder/file_io_type_dump.hpp index a8af4ca..a6918b9 100644 --- a/oem/ibm/libpldmresponder/file_io_type_dump.hpp +++ b/oem/ibm/libpldmresponder/file_io_type_dump.hpp
@@ -22,42 +22,40 @@ FileHandler(fileHandle), dumpType(fileType) {} - virtual int writeFromMemory(uint32_t offset, uint32_t length, - uint64_t address, - oem_platform::Handler* /*oemPlatformHandler*/); + int writeFromMemory(uint32_t offset, uint32_t length, uint64_t address, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int readIntoMemory(uint32_t offset, uint32_t length, - uint64_t address, - oem_platform::Handler* /*oemPlatformHandler*/); + int readIntoMemory(uint32_t offset, uint32_t length, uint64_t address, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int read(uint32_t offset, uint32_t& length, Response& response, - oem_platform::Handler* /*oemPlatformHandler*/); + int read(uint32_t offset, uint32_t& length, Response& response, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int write(const char* buffer, uint32_t offset, uint32_t& length, - oem_platform::Handler* /*oemPlatformHandler*/); + int write(const char* buffer, uint32_t offset, uint32_t& length, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int newFileAvailable(uint64_t length); + int newFileAvailable(uint64_t length) override; - virtual int fileAck(uint8_t fileStatus); + int fileAck(uint8_t fileStatus) override; - virtual int fileAckWithMetaData( - uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, - uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/) + int fileAckWithMetaData(uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, + uint32_t /*metaDataValue2*/, + uint32_t /*metaDataValue3*/, + uint32_t /*metaDataValue4*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int newFileAvailableWithMetaData( + int newFileAvailableWithMetaData( uint64_t length, uint32_t metaDataValue1, uint32_t /*metaDataValue2*/, - uint32_t /*metaDataValue3*/, uint32_t /*metaDataValue4*/); + uint32_t /*metaDataValue3*/, uint32_t /*metaDataValue4*/) override; std::string findDumpObjPath(uint32_t fileHandle) const; std::string getOffloadUri(uint32_t fileHandle) const; /** @brief DumpHandler destructor */ - ~DumpHandler() {} + ~DumpHandler() override {} private: static int fd; //!< fd to manage the dump offload to bmc
diff --git a/oem/ibm/libpldmresponder/file_io_type_lid.hpp b/oem/ibm/libpldmresponder/file_io_type_lid.hpp index 4829773..e64d7e0 100644 --- a/oem/ibm/libpldmresponder/file_io_type_lid.hpp +++ b/oem/ibm/libpldmresponder/file_io_type_lid.hpp
@@ -99,9 +99,8 @@ return true; } - virtual int writeFromMemory(uint32_t offset, uint32_t length, - uint64_t address, - oem_platform::Handler* oemPlatformHandler) + int writeFromMemory(uint32_t offset, uint32_t length, uint64_t address, + oem_platform::Handler* oemPlatformHandler) override { int rc = PLDM_SUCCESS; bool codeUpdateInProgress = false; @@ -172,9 +171,8 @@ return rc; } - virtual int readIntoMemory(uint32_t offset, uint32_t length, - uint64_t address, - oem_platform::Handler* oemPlatformHandler) + int readIntoMemory(uint32_t offset, uint32_t length, uint64_t address, + oem_platform::Handler* oemPlatformHandler) override { if (constructLIDPath(oemPlatformHandler)) { @@ -183,8 +181,8 @@ return PLDM_ERROR; } - virtual int write(const char* buffer, uint32_t offset, uint32_t& length, - oem_platform::Handler* oemPlatformHandler) + int write(const char* buffer, uint32_t offset, uint32_t& length, + oem_platform::Handler* oemPlatformHandler) override { int rc = PLDM_SUCCESS; bool codeUpdateInProgress = false; @@ -287,8 +285,8 @@ return rc; } - virtual int read(uint32_t offset, uint32_t& length, Response& response, - oem_platform::Handler* oemPlatformHandler) + int read(uint32_t offset, uint32_t& length, Response& response, + oem_platform::Handler* oemPlatformHandler) override { if (constructLIDPath(oemPlatformHandler)) { @@ -297,12 +295,12 @@ return PLDM_ERROR; } - virtual int fileAck(uint8_t /*fileStatus*/) + int fileAck(uint8_t /*fileStatus*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int newFileAvailable(uint64_t length) + int newFileAvailable(uint64_t length) override { if (lidType == PLDM_FILE_TYPE_LID_MARKER) @@ -313,25 +311,25 @@ return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int fileAckWithMetaData( - uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, - uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/) + int fileAckWithMetaData(uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, + uint32_t /*metaDataValue2*/, + uint32_t /*metaDataValue3*/, + uint32_t /*metaDataValue4*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int newFileAvailableWithMetaData( + int newFileAvailableWithMetaData( uint64_t /*length*/, uint32_t /*metaDataValue1*/, uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/) + uint32_t /*metaDataValue4*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } /** @brief LidHandler destructor */ - ~LidHandler() {} + ~LidHandler() override {} protected: std::string lidPath;
diff --git a/oem/ibm/libpldmresponder/file_io_type_pcie.hpp b/oem/ibm/libpldmresponder/file_io_type_pcie.hpp index 89bd2a6..7a310dc 100644 --- a/oem/ibm/libpldmresponder/file_io_type_pcie.hpp +++ b/oem/ibm/libpldmresponder/file_io_type_pcie.hpp
@@ -141,46 +141,44 @@ */ PCIeInfoHandler(uint32_t fileHandle, uint16_t fileType); - virtual int writeFromMemory(uint32_t offset, uint32_t length, - uint64_t address, - oem_platform::Handler* /*oemPlatformHandler*/); + int writeFromMemory(uint32_t offset, uint32_t length, uint64_t address, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int write(const char* buffer, uint32_t offset, uint32_t& length, - oem_platform::Handler* /*oemPlatformHandler*/); + int write(const char* buffer, uint32_t offset, uint32_t& length, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int fileAck(uint8_t fileStatus); + int fileAck(uint8_t fileStatus) override; - virtual int readIntoMemory(uint32_t /*offset*/, uint32_t /*length*/, - uint64_t /*address*/, - oem_platform::Handler* /*oemPlatformHandler*/) + int readIntoMemory(uint32_t /*offset*/, uint32_t /*length*/, + uint64_t /*address*/, + oem_platform::Handler* /*oemPlatformHandler*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int read(uint32_t /*offset*/, uint32_t& /*length*/, - Response& /*response*/, - oem_platform::Handler* /*oemPlatformHandler*/) + int read(uint32_t /*offset*/, uint32_t& /*length*/, Response& /*response*/, + oem_platform::Handler* /*oemPlatformHandler*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int newFileAvailable(uint64_t /*length*/) + int newFileAvailable(uint64_t /*length*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int fileAckWithMetaData( - uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, - uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/) + int fileAckWithMetaData(uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, + uint32_t /*metaDataValue2*/, + uint32_t /*metaDataValue3*/, + uint32_t /*metaDataValue4*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int newFileAvailableWithMetaData( + int newFileAvailableWithMetaData( uint64_t /*length*/, uint32_t /*metaDataValue1*/, uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/) + uint32_t /*metaDataValue4*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } @@ -193,7 +191,7 @@ /** @brief PCIeInfoHandler destructor */ - ~PCIeInfoHandler() {} + ~PCIeInfoHandler() override {} private: uint16_t infoType; //!< type of the information
diff --git a/oem/ibm/libpldmresponder/file_io_type_pel.hpp b/oem/ibm/libpldmresponder/file_io_type_pel.hpp index 4fbc642..0c073b6 100644 --- a/oem/ibm/libpldmresponder/file_io_type_pel.hpp +++ b/oem/ibm/libpldmresponder/file_io_type_pel.hpp
@@ -19,27 +19,24 @@ */ explicit PelHandler(uint32_t fileHandle) : FileHandler(fileHandle) {} - virtual int writeFromMemory(uint32_t offset, uint32_t length, - uint64_t address, - oem_platform::Handler* /*oemPlatformHandler*/); + int writeFromMemory(uint32_t offset, uint32_t length, uint64_t address, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int readIntoMemory(uint32_t offset, uint32_t length, - uint64_t address, - oem_platform::Handler* /*oemPlatformHandler*/); + int readIntoMemory(uint32_t offset, uint32_t length, uint64_t address, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int read(uint32_t offset, uint32_t& length, Response& response, - oem_platform::Handler* /*oemPlatformHandler*/); + int read(uint32_t offset, uint32_t& length, Response& response, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int write(const char* /*buffer*/, uint32_t /*offset*/, - uint32_t& /*length*/, - oem_platform::Handler* /*oemPlatformHandler*/); + int write(const char* /*buffer*/, uint32_t /*offset*/, uint32_t& /*length*/, + oem_platform::Handler* /*oemPlatformHandler*/) override; - virtual int fileAck(uint8_t fileStatus); + int fileAck(uint8_t fileStatus) override; - virtual int fileAckWithMetaData( - uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, - uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/) + int fileAckWithMetaData(uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, + uint32_t /*metaDataValue2*/, + uint32_t /*metaDataValue3*/, + uint32_t /*metaDataValue4*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } @@ -51,22 +48,22 @@ */ virtual int storePel(std::string&& pelFileName); - virtual int newFileAvailable(uint64_t /*length*/) + int newFileAvailable(uint64_t /*length*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int newFileAvailableWithMetaData( + int newFileAvailableWithMetaData( uint64_t /*length*/, uint32_t /*metaDataValue1*/, uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/) + uint32_t /*metaDataValue4*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } /** @brief PelHandler destructor */ - ~PelHandler() {} + ~PelHandler() override {} }; } // namespace responder
diff --git a/oem/ibm/libpldmresponder/file_io_type_progress_src.hpp b/oem/ibm/libpldmresponder/file_io_type_progress_src.hpp index ff16040..f916148 100644 --- a/oem/ibm/libpldmresponder/file_io_type_progress_src.hpp +++ b/oem/ibm/libpldmresponder/file_io_type_progress_src.hpp
@@ -54,7 +54,7 @@ return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int newFileAvailableWithMetaData( + int newFileAvailableWithMetaData( uint64_t /*length*/, uint32_t /*metaDataValue1*/, uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, uint32_t /*metaDataValue4*/) override @@ -71,10 +71,10 @@ const std::tuple<std::vector<uint8_t>, std::vector<uint8_t>>& progressCodeBuffer); - virtual int fileAckWithMetaData( - uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, - uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/) override + int fileAckWithMetaData(uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, + uint32_t /*metaDataValue2*/, + uint32_t /*metaDataValue3*/, + uint32_t /*metaDataValue4*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } @@ -82,7 +82,7 @@ /** @brief ProgressCodeHandler destructor */ - ~ProgressCodeHandler() {} + ~ProgressCodeHandler() override {} }; } // namespace responder
diff --git a/oem/ibm/libpldmresponder/file_io_type_vpd.hpp b/oem/ibm/libpldmresponder/file_io_type_vpd.hpp index b06c6a1..602a4d9 100644 --- a/oem/ibm/libpldmresponder/file_io_type_vpd.hpp +++ b/oem/ibm/libpldmresponder/file_io_type_vpd.hpp
@@ -20,51 +20,50 @@ keywordHandler(uint32_t fileHandle, uint16_t /* fileType */) : FileHandler(fileHandle) {} - virtual int writeFromMemory(uint32_t /*offset*/, uint32_t /*length*/, - uint64_t /*address*/, - oem_platform::Handler* /*oemPlatformHandler*/) + int writeFromMemory(uint32_t /*offset*/, uint32_t /*length*/, + uint64_t /*address*/, + oem_platform::Handler* /*oemPlatformHandler*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int readIntoMemory(uint32_t /*offset*/, uint32_t /*length*/, - uint64_t /*address*/, - oem_platform::Handler* /*oemPlatformHandler*/) + int readIntoMemory(uint32_t /*offset*/, uint32_t /*length*/, + uint64_t /*address*/, + oem_platform::Handler* /*oemPlatformHandler*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int read(uint32_t offset, uint32_t& length, Response& response, - oem_platform::Handler* /*oemPlatformHandler*/); - virtual int write(const char* /*buffer*/, uint32_t /*offset*/, - uint32_t& /*length*/, - oem_platform::Handler* /*oemPlatformHandler*/) + int read(uint32_t offset, uint32_t& length, Response& response, + oem_platform::Handler* /*oemPlatformHandler*/) override; + int write(const char* /*buffer*/, uint32_t /*offset*/, uint32_t& /*length*/, + oem_platform::Handler* /*oemPlatformHandler*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int fileAck(uint8_t /*fileStatus*/) + int fileAck(uint8_t /*fileStatus*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int newFileAvailable(uint64_t /*length*/) + int newFileAvailable(uint64_t /*length*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int fileAckWithMetaData( - uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, - uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/) + int fileAckWithMetaData(uint8_t /*fileStatus*/, uint32_t /*metaDataValue1*/, + uint32_t /*metaDataValue2*/, + uint32_t /*metaDataValue3*/, + uint32_t /*metaDataValue4*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } - virtual int newFileAvailableWithMetaData( + int newFileAvailableWithMetaData( uint64_t /*length*/, uint32_t /*metaDataValue1*/, uint32_t /*metaDataValue2*/, uint32_t /*metaDataValue3*/, - uint32_t /*metaDataValue4*/) + uint32_t /*metaDataValue4*/) override { return PLDM_ERROR_UNSUPPORTED_PLDM_CMD; } /** @brief keywordHandler destructor */ - ~keywordHandler() {} + ~keywordHandler() override {} }; } // namespace responder } // namespace pldm
diff --git a/oem/ibm/libpldmresponder/fru_oem_ibm.hpp b/oem/ibm/libpldmresponder/fru_oem_ibm.hpp index e1cc568..f3b4934 100644 --- a/oem/ibm/libpldmresponder/fru_oem_ibm.hpp +++ b/oem/ibm/libpldmresponder/fru_oem_ibm.hpp
@@ -48,14 +48,14 @@ * * @return success or failure */ - int processOEMFRUTable(const std::vector<uint8_t>& fruData); + int processOEMFRUTable(const std::vector<uint8_t>& fruData) override; virtual const AssociatedEntityMap& getAssociateEntityMap() { return fruHandler->getAssociateEntityMap(); } - ~Handler() = default; + ~Handler() override = default; private: /** @brief pointer to BMC's primary PDR repo */
diff --git a/oem/ibm/libpldmresponder/oem_ibm_handler.hpp b/oem/ibm/libpldmresponder/oem_ibm_handler.hpp index 13b3134..f4f63fd 100644 --- a/oem/ibm/libpldmresponder/oem_ibm_handler.hpp +++ b/oem/ibm/libpldmresponder/oem_ibm_handler.hpp
@@ -232,12 +232,13 @@ pldm::pdr::EntityInstance entityInstance, pldm::pdr::ContainerID containerId, pldm::pdr::StateSetId stateSetId, pldm::pdr::CompositeCount compSensorCnt, uint16_t sensorId, - std::vector<get_sensor_state_field>& stateField); + std::vector<get_sensor_state_field>& stateField) override; int oemSetStateEffecterStatesHandler( uint16_t entityType, uint16_t entityInstance, uint16_t stateSetId, uint8_t compEffecterCnt, - std::vector<set_effecter_state_field>& stateField, uint16_t effecterId); + std::vector<set_effecter_state_field>& stateField, + uint16_t effecterId) override; /** @brief Method to set the platform handler in the * oem_ibm_handler class @@ -280,7 +281,7 @@ * * @param[in] repo - instance of concrete implementation of Repo */ - void buildOEMPDR(pdr_utils::Repo& repo); + void buildOEMPDR(pdr_utils::Repo& repo) override; /** @brief Method to send code update event to host * @param[in] sensorId - sendor ID @@ -324,33 +325,33 @@ void _processSystemReboot(sdeventplus::source::EventBase& source); /*keeps track how many times setEventReceiver is sent */ - void countSetEventReceiver() + void countSetEventReceiver() override { setEventReceiverCnt++; } /* disables watchdog if running and Host is up */ - void checkAndDisableWatchDog(); + void checkAndDisableWatchDog() override; /** @brief To check if the watchdog app is running * * @return the running status of watchdog app */ - bool watchDogRunning(); + bool watchDogRunning() override; /** @brief Method to reset the Watchdog timer on receiving platform Event * Message for heartbeat elapsed time from Hostboot */ - void resetWatchDogTimer(); + void resetWatchDogTimer() override; /** @brief To disable to the watchdog timer on host poweron completion*/ - void disableWatchDogTimer(); + void disableWatchDogTimer() override; /** @brief to check the BMC state*/ - int checkBMCState(); + int checkBMCState() override; /** @brief update the dbus object paths */ - void updateOemDbusPaths(std::string& dbusPath); + void updateOemDbusPaths(std::string& dbusPath) override; /** @brief Method to fetch the last BMC record from the PDR repo * @@ -358,7 +359,7 @@ * * @return the last BMC record from the repo */ - const pldm_pdr_record* fetchLastBMCRecord(const pldm_pdr* repo); + const pldm_pdr_record* fetchLastBMCRecord(const pldm_pdr* repo) override; /** @brief Method to check if the record handle passed is in remote PDR * record handle range @@ -367,10 +368,10 @@ * * @return true if record handle passed is in host PDR record handle range */ - bool checkRecordHandleInRange(const uint32_t& record_handle); + bool checkRecordHandleInRange(const uint32_t& record_handle) override; /** *brief Method to call the setEventReceiver command*/ - void processSetEventReceiver(); + void processSetEventReceiver() override; /** @brief Method to call the setEventReceiver through the platform * handler @@ -388,13 +389,13 @@ * @param[in] value - true or false, to indicate if the timer is * running or not */ - void setSurvTimer(uint8_t tid, bool value); + void setSurvTimer(uint8_t tid, bool value) override; /** @brief To handle the boot types bios attributes at power on*/ - void handleBootTypesAtPowerOn(); + void handleBootTypesAtPowerOn() override; /** @brief To handle the boot types bios attributes at shutdown*/ - void handleBootTypesAtChassisOff(); + void handleBootTypesAtChassisOff() override; /** @brief To set the boot types bios attributes based on the RestartCause * of host @@ -416,7 +417,7 @@ /** @brief Method to process virtual platform/partition SAI update*/ void processSAIUpdate(); - ~Handler() = default; + ~Handler() override = default; pldm::responder::CodeUpdate* codeUpdate; //!< pointer to CodeUpdate object @@ -513,7 +514,7 @@ public: Handler() {} - void processOEMBaseBiosTable(const BaseBIOSTable& biosTable) + void processOEMBaseBiosTable(const BaseBIOSTable& biosTable) override { for (const auto& [attrName, biostabObj] : biosTable) {
diff --git a/oem/ibm/libpldmresponder/utils.hpp b/oem/ibm/libpldmresponder/utils.hpp index 657e9fe..0da9aef 100644 --- a/oem/ibm/libpldmresponder/utils.hpp +++ b/oem/ibm/libpldmresponder/utils.hpp
@@ -73,11 +73,10 @@ * @param[in] entityMaps - the mapping of entity to DBus string * */ - virtual int setCoreCount( - const pldm::utils::EntityAssociations& associations, - const pldm::utils::EntityMaps entityMaps); + int setCoreCount(const pldm::utils::EntityAssociations& associations, + const pldm::utils::EntityMaps entityMaps) override; - virtual ~Handler() = default; + ~Handler() override = default; protected: const pldm::utils::DBusHandler* dBusIntf;
diff --git a/oem/meta/libpldmresponder/file_io.hpp b/oem/meta/libpldmresponder/file_io.hpp index a5f29b0..2d5a1d4 100644 --- a/oem/meta/libpldmresponder/file_io.hpp +++ b/oem/meta/libpldmresponder/file_io.hpp
@@ -21,7 +21,7 @@ FileIOHandler(FileIOHandler&&) = delete; FileIOHandler& operator=(const FileIOHandler&) = delete; FileIOHandler& operator=(FileIOHandler&&) = delete; - virtual ~FileIOHandler() = default; + ~FileIOHandler() override = default; explicit FileIOHandler(const pldm::utils::DBusHandler* dBusHandler) : dBusHandler(dBusHandler)
diff --git a/oem/meta/libpldmresponder/file_io_type_bios_version.hpp b/oem/meta/libpldmresponder/file_io_type_bios_version.hpp index 56cd9af..2782e13 100644 --- a/oem/meta/libpldmresponder/file_io_type_bios_version.hpp +++ b/oem/meta/libpldmresponder/file_io_type_bios_version.hpp
@@ -25,7 +25,7 @@ tid(tid), dBusIntf(dBusIntf) {} - ~BIOSVersionHandler() = default; + ~BIOSVersionHandler() override = default; /** @brief Method to set Host's BIOS version. * @param[in] data - BIOS version raw data.
diff --git a/oem/meta/libpldmresponder/file_io_type_event_log.hpp b/oem/meta/libpldmresponder/file_io_type_event_log.hpp index 22fdd6b..cccac87 100644 --- a/oem/meta/libpldmresponder/file_io_type_event_log.hpp +++ b/oem/meta/libpldmresponder/file_io_type_event_log.hpp
@@ -21,13 +21,13 @@ explicit EventLogHandler(pldm_tid_t tid) : tid(tid) {} - ~EventLogHandler() = default; + ~EventLogHandler() override = default; /** @brief Method to parse event log from eventList * @param[in] data - eventData * @return PLDM status code */ - int write(const message& data); + int write(const message& data) override; private: /** @brief The terminus ID of the message source*/
diff --git a/oem/meta/libpldmresponder/file_io_type_http_boot.hpp b/oem/meta/libpldmresponder/file_io_type_http_boot.hpp index cc908bd..aba53f6 100644 --- a/oem/meta/libpldmresponder/file_io_type_http_boot.hpp +++ b/oem/meta/libpldmresponder/file_io_type_http_boot.hpp
@@ -20,7 +20,7 @@ HttpBootHandler& operator=(const HttpBootHandler&) = delete; HttpBootHandler& operator=(HttpBootHandler&&) = delete; - ~HttpBootHandler() = default; + ~HttpBootHandler() override = default; /** @brief Method to parse read file IO for Http Boot command (type: 0x03) * and returning the Http boot certification stored in BMC.
diff --git a/oem/meta/libpldmresponder/file_io_type_post_code.hpp b/oem/meta/libpldmresponder/file_io_type_post_code.hpp index 626f622..d51f988 100644 --- a/oem/meta/libpldmresponder/file_io_type_post_code.hpp +++ b/oem/meta/libpldmresponder/file_io_type_post_code.hpp
@@ -20,7 +20,7 @@ explicit PostCodeHandler(pldm_tid_t tid) : tid(tid) {} - ~PostCodeHandler() = default; + ~PostCodeHandler() override = default; /** @brief Method to store postcode list * @param[in] data - post code
diff --git a/oem/meta/libpldmresponder/file_io_type_power_control.hpp b/oem/meta/libpldmresponder/file_io_type_power_control.hpp index 2073514..f7e6c33 100644 --- a/oem/meta/libpldmresponder/file_io_type_power_control.hpp +++ b/oem/meta/libpldmresponder/file_io_type_power_control.hpp
@@ -24,7 +24,7 @@ tid(tid), dBusIntf(dBusIntf) {} - ~PowerControlHandler() = default; + ~PowerControlHandler() override = default; /** @brief Method to add handler for write-file command * "SLED_CYCLE, 12V-CYCLE and DC-cycle" to let
diff --git a/platform-mc/manager.hpp b/platform-mc/manager.hpp index b21a66c..056d7bc 100644 --- a/platform-mc/manager.hpp +++ b/platform-mc/manager.hpp
@@ -32,7 +32,7 @@ Manager(Manager&&) = delete; Manager& operator=(const Manager&) = delete; Manager& operator=(Manager&&) = delete; - ~Manager() = default; + ~Manager() override = default; explicit Manager(sdeventplus::Event& event, RequesterHandler& handler, pldm::InstanceIdDb& instanceIdDb) : @@ -60,7 +60,7 @@ * * @param[in] mctpInfos - list information of the MCTP endpoints */ - void handleMctpEndpoints(const MctpInfos& mctpInfos) + void handleMctpEndpoints(const MctpInfos& mctpInfos) override { terminusManager.discoverMctpTerminus(mctpInfos); } @@ -70,7 +70,7 @@ * * @param[in] mctpInfos - list information of the MCTP endpoints */ - void handleRemovedMctpEndpoints(const MctpInfos& mctpInfos) + void handleRemovedMctpEndpoints(const MctpInfos& mctpInfos) override { terminusManager.removeMctpTerminus(mctpInfos); } @@ -82,7 +82,7 @@ * @param[in] availability - new availability status */ void updateMctpEndpointAvailability(const MctpInfo& mctpInfo, - Availability availability) + Availability availability) override { /* Get TID of initialized terminus */ auto tid = terminusManager.toTid(mctpInfo); @@ -260,7 +260,7 @@ * @param[in] terminiNames - MCTP terminus name */ std::optional<mctp_eid_t> getActiveEidByName( - const std::string& terminusName) + const std::string& terminusName) override { return terminusManager.getActiveEidByName(terminusName); }
diff --git a/pldmd/dbus_impl_pdr.hpp b/pldmd/dbus_impl_pdr.hpp index 39f411b..be6c65e 100644 --- a/pldmd/dbus_impl_pdr.hpp +++ b/pldmd/dbus_impl_pdr.hpp
@@ -31,7 +31,7 @@ Pdr& operator=(const Pdr&) = delete; Pdr(Pdr&&) = delete; Pdr& operator=(Pdr&&) = delete; - virtual ~Pdr() = default; + ~Pdr() override = default; /** @brief Constructor to put object onto bus at a dbus path. * @param[in] bus - Bus to attach to.
diff --git a/pldmtool/oem/ibm/pldm_oem_ibm.cpp b/pldmtool/oem/ibm/pldm_oem_ibm.cpp index 9f8827b..1df7627 100644 --- a/pldmtool/oem/ibm/pldm_oem_ibm.cpp +++ b/pldmtool/oem/ibm/pldm_oem_ibm.cpp
@@ -34,7 +34,7 @@ class GetAlertStatus : public CommandInterface { public: - ~GetAlertStatus() = default; + ~GetAlertStatus() override = default; GetAlertStatus() = delete; GetAlertStatus(const GetAlertStatus&) = delete; GetAlertStatus(GetAlertStatus&&) = default; @@ -96,7 +96,7 @@ class GetFileTable : public CommandInterface { public: - ~GetFileTable() = default; + ~GetFileTable() override = default; GetFileTable() = delete; GetFileTable(const GetFileTable&) = delete; GetFileTable(GetFileTable&&) = default;
diff --git a/pldmtool/pldm_base_cmd.cpp b/pldmtool/pldm_base_cmd.cpp index f6760a2..258bae4 100644 --- a/pldmtool/pldm_base_cmd.cpp +++ b/pldmtool/pldm_base_cmd.cpp
@@ -216,7 +216,7 @@ class GetPLDMTypes : public CommandInterface { public: - ~GetPLDMTypes() = default; + ~GetPLDMTypes() override = default; GetPLDMTypes() = delete; GetPLDMTypes(const GetPLDMTypes&) = delete; GetPLDMTypes(GetPLDMTypes&&) = default; @@ -288,7 +288,7 @@ class GetPLDMVersion : public CommandInterface { public: - ~GetPLDMVersion() = default; + ~GetPLDMVersion() override = default; GetPLDMVersion() = delete; GetPLDMVersion(const GetPLDMVersion&) = delete; GetPLDMVersion(GetPLDMVersion&&) = default; @@ -354,7 +354,7 @@ class GetTID : public CommandInterface { public: - ~GetTID() = default; + ~GetTID() override = default; GetTID() = delete; GetTID(const GetTID&) = delete; GetTID(GetTID&&) = default; @@ -392,7 +392,7 @@ class GetPLDMCommands : public CommandInterface { public: - ~GetPLDMCommands() = default; + ~GetPLDMCommands() override = default; GetPLDMCommands() = delete; GetPLDMCommands(const GetPLDMCommands&) = delete; GetPLDMCommands(GetPLDMCommands&&) = default; @@ -531,7 +531,7 @@ class SetTID : public CommandInterface { public: - ~SetTID() = default; + ~SetTID() override = default; SetTID() = delete; SetTID(const SetTID&) = delete; SetTID(SetTID&&) = default;
diff --git a/pldmtool/pldm_bios_cmd.cpp b/pldmtool/pldm_bios_cmd.cpp index 94bd263..77e7268 100644 --- a/pldmtool/pldm_bios_cmd.cpp +++ b/pldmtool/pldm_bios_cmd.cpp
@@ -36,7 +36,7 @@ class GetDateTime : public CommandInterface { public: - ~GetDateTime() = default; + ~GetDateTime() override = default; GetDateTime() = delete; GetDateTime(const GetDateTime&) = delete; GetDateTime(GetDateTime&&) = default; @@ -92,7 +92,7 @@ class SetDateTime : public CommandInterface { public: - ~SetDateTime() = default; + ~SetDateTime() override = default; SetDateTime() = delete; SetDateTime(const SetDateTime&) = delete; SetDateTime(SetDateTime&&) = default; @@ -162,7 +162,7 @@ class GetBIOSTableHandler : public CommandInterface { public: - ~GetBIOSTableHandler() = default; + ~GetBIOSTableHandler() override = default; GetBIOSTableHandler() = delete; GetBIOSTableHandler(const GetBIOSTableHandler&) = delete; GetBIOSTableHandler(GetBIOSTableHandler&&) = delete; @@ -445,7 +445,7 @@ class GetBIOSTable : public GetBIOSTableHandler { public: - ~GetBIOSTable() = default; + ~GetBIOSTable() override = default; GetBIOSTable() = delete; GetBIOSTable(const GetBIOSTable&) = delete; GetBIOSTable(GetBIOSTable&&) = delete; @@ -671,7 +671,7 @@ class GetBIOSAttributeCurrentValueByHandle : public GetBIOSTableHandler { public: - ~GetBIOSAttributeCurrentValueByHandle() = default; + ~GetBIOSAttributeCurrentValueByHandle() override = default; GetBIOSAttributeCurrentValueByHandle( const GetBIOSAttributeCurrentValueByHandle&) = delete; GetBIOSAttributeCurrentValueByHandle( @@ -689,7 +689,7 @@ ->required(); } - void exec() + void exec() override { auto stringTable = getBIOSTable(PLDM_BIOS_STRING_TABLE); auto attrTable = getBIOSTable(PLDM_BIOS_ATTR_TABLE); @@ -761,7 +761,7 @@ class SetBIOSAttributeCurrentValue : public GetBIOSTableHandler { public: - ~SetBIOSAttributeCurrentValue() = default; + ~SetBIOSAttributeCurrentValue() override = default; SetBIOSAttributeCurrentValue() = delete; SetBIOSAttributeCurrentValue(const SetBIOSAttributeCurrentValue&) = delete; SetBIOSAttributeCurrentValue(SetBIOSAttributeCurrentValue&&) = delete; @@ -781,7 +781,7 @@ // -v is conflict with --verbose in class CommandInterface, so used -d } - void exec() + void exec() override { auto stringTable = getBIOSTable(PLDM_BIOS_STRING_TABLE); auto attrTable = getBIOSTable(PLDM_BIOS_ATTR_TABLE);
diff --git a/pldmtool/pldm_fru_cmd.cpp b/pldmtool/pldm_fru_cmd.cpp index 395ec5c..5b23dff 100644 --- a/pldmtool/pldm_fru_cmd.cpp +++ b/pldmtool/pldm_fru_cmd.cpp
@@ -26,7 +26,7 @@ class GetFruRecordTableMetadata : public CommandInterface { public: - ~GetFruRecordTableMetadata() = default; + ~GetFruRecordTableMetadata() override = default; GetFruRecordTableMetadata() = delete; GetFruRecordTableMetadata(const GetFruRecordTableMetadata&) = delete; GetFruRecordTableMetadata(GetFruRecordTableMetadata&&) = default; @@ -312,7 +312,7 @@ class GetFRURecordByOption : public CommandInterface { public: - ~GetFRURecordByOption() = default; + ~GetFRURecordByOption() override = default; GetFRURecordByOption() = delete; GetFRURecordByOption(const GetFRURecordByOption&) = delete; GetFRURecordByOption& operator=(const GetFRURecordByOption&) = delete; @@ -397,7 +397,7 @@ class GetFruRecordTable : public CommandInterface { public: - ~GetFruRecordTable() = default; + ~GetFruRecordTable() override = default; GetFruRecordTable() = delete; GetFruRecordTable(const GetFruRecordTable&) = delete; GetFruRecordTable(GetFruRecordTable&&) = default;
diff --git a/pldmtool/pldm_fw_update_cmd.cpp b/pldmtool/pldm_fw_update_cmd.cpp index e54d00f..98ffbcd 100644 --- a/pldmtool/pldm_fw_update_cmd.cpp +++ b/pldmtool/pldm_fw_update_cmd.cpp
@@ -119,7 +119,7 @@ class GetStatus : public CommandInterface { public: - ~GetStatus() = default; + ~GetStatus() override = default; GetStatus() = delete; GetStatus(const GetStatus&) = delete; GetStatus(GetStatus&&) = default; @@ -209,7 +209,7 @@ class GetFirmwareParameters : public CommandInterface { public: - ~GetFirmwareParameters() = default; + ~GetFirmwareParameters() override = default; GetFirmwareParameters() = delete; GetFirmwareParameters(const GetFirmwareParameters&) = delete; GetFirmwareParameters(GetFirmwareParameters&&) = default; @@ -455,7 +455,7 @@ class QueryDeviceIdentifiers : public CommandInterface { public: - ~QueryDeviceIdentifiers() = default; + ~QueryDeviceIdentifiers() override = default; QueryDeviceIdentifiers() = delete; QueryDeviceIdentifiers(const QueryDeviceIdentifiers&) = delete; QueryDeviceIdentifiers(QueryDeviceIdentifiers&&) = default; @@ -658,7 +658,7 @@ class RequestUpdate : public CommandInterface { public: - ~RequestUpdate() = default; + ~RequestUpdate() override = default; RequestUpdate() = delete; RequestUpdate(const RequestUpdate&) = delete; RequestUpdate(RequestUpdate&&) = delete; @@ -807,7 +807,7 @@ class PassComponentTable : public CommandInterface { public: - ~PassComponentTable() = default; + ~PassComponentTable() override = default; PassComponentTable() = delete; PassComponentTable(const PassComponentTable&) = delete; PassComponentTable(PassComponentTable&&) = delete; @@ -967,7 +967,7 @@ class UpdateComponent : public CommandInterface { public: - ~UpdateComponent() = default; + ~UpdateComponent() override = default; UpdateComponent() = delete; UpdateComponent(const UpdateComponent&) = delete; UpdateComponent(UpdateComponent&&) = delete; @@ -1156,7 +1156,7 @@ class ActivateFirmware : public CommandInterface { public: - ~ActivateFirmware() = default; + ~ActivateFirmware() override = default; ActivateFirmware() = delete; ActivateFirmware(const ActivateFirmware&) = delete; ActivateFirmware(ActivateFirmware&&) = delete; @@ -1218,7 +1218,7 @@ class CancelUpdateComponent : public CommandInterface { public: - ~CancelUpdateComponent() = default; + ~CancelUpdateComponent() override = default; CancelUpdateComponent() = delete; CancelUpdateComponent(const CancelUpdateComponent&) = delete; CancelUpdateComponent(CancelUpdateComponent&&) = delete; @@ -1259,7 +1259,7 @@ class CancelUpdate : public CommandInterface { public: - ~CancelUpdate() = default; + ~CancelUpdate() override = default; CancelUpdate() = delete; CancelUpdate(const CancelUpdate&) = delete; CancelUpdate(CancelUpdate&&) = delete; @@ -1316,7 +1316,7 @@ class UpdateSecurityRevision : public CommandInterface { public: - ~UpdateSecurityRevision() = default; + ~UpdateSecurityRevision() override = default; UpdateSecurityRevision() = delete; UpdateSecurityRevision(const UpdateSecurityRevision&) = delete; UpdateSecurityRevision(UpdateSecurityRevision&&) = delete;
diff --git a/pldmtool/pldm_platform_cmd.cpp b/pldmtool/pldm_platform_cmd.cpp index 00f7af9..8cd5f83 100644 --- a/pldmtool/pldm_platform_cmd.cpp +++ b/pldmtool/pldm_platform_cmd.cpp
@@ -79,7 +79,7 @@ class GetEventReceiver : public CommandInterface { public: - ~GetEventReceiver() = default; + ~GetEventReceiver() override = default; GetEventReceiver() = delete; GetEventReceiver(const GetEventReceiver&) = delete; GetEventReceiver(GetEventReceiver&&) = default; @@ -405,7 +405,7 @@ class GetPDR : public CommandInterface { public: - ~GetPDR() = default; + ~GetPDR() override = default; GetPDR() = delete; GetPDR(const GetPDR&) = delete; GetPDR(GetPDR&&) = default; @@ -2012,7 +2012,7 @@ class SetStateEffecter : public CommandInterface { public: - ~SetStateEffecter() = default; + ~SetStateEffecter() override = default; SetStateEffecter() = delete; SetStateEffecter(const SetStateEffecter&) = delete; SetStateEffecter(SetStateEffecter&&) = default; @@ -2110,7 +2110,7 @@ class SetNumericEffecterValue : public CommandInterface { public: - ~SetNumericEffecterValue() = default; + ~SetNumericEffecterValue() override = default; SetNumericEffecterValue() = delete; SetNumericEffecterValue(const SetNumericEffecterValue&) = delete; SetNumericEffecterValue(SetNumericEffecterValue&&) = default; @@ -2193,7 +2193,7 @@ class GetStateSensorReadings : public CommandInterface { public: - ~GetStateSensorReadings() = default; + ~GetStateSensorReadings() override = default; GetStateSensorReadings() = delete; GetStateSensorReadings(const GetStateSensorReadings&) = delete; GetStateSensorReadings(GetStateSensorReadings&&) = default; @@ -2287,7 +2287,7 @@ class GetSensorReading : public CommandInterface { public: - ~GetSensorReading() = default; + ~GetSensorReading() override = default; GetSensorReading() = delete; GetSensorReading(const GetSensorReading&) = delete; GetSensorReading(GetSensorReading&&) = default; @@ -2443,7 +2443,7 @@ class GetStateEffecterStates : public CommandInterface { public: - ~GetStateEffecterStates() = default; + ~GetStateEffecterStates() override = default; GetStateEffecterStates() = delete; GetStateEffecterStates(const GetStateEffecterStates&) = delete; GetStateEffecterStates(GetStateEffecterStates&&) = default; @@ -2512,7 +2512,7 @@ class GetNumericEffecterValue : public CommandInterface { public: - ~GetNumericEffecterValue() = default; + ~GetNumericEffecterValue() override = default; GetNumericEffecterValue() = delete; GetNumericEffecterValue(const GetNumericEffecterValue&) = delete; GetNumericEffecterValue(GetNumericEffecterValue&&) = default;
diff --git a/pldmtool/pldmtool.cpp b/pldmtool/pldmtool.cpp index cdd157a..d230eaa 100644 --- a/pldmtool/pldmtool.cpp +++ b/pldmtool/pldmtool.cpp
@@ -24,7 +24,7 @@ class RawOp : public CommandInterface { public: - ~RawOp() = default; + ~RawOp() override = default; RawOp() = delete; RawOp(const RawOp&) = delete; RawOp(RawOp&&) = default;
diff --git a/requester/request.hpp b/requester/request.hpp index 3de5c8a..71dc5b3 100644 --- a/requester/request.hpp +++ b/requester/request.hpp
@@ -136,7 +136,7 @@ Request(Request&&) = delete; Request& operator=(const Request&) = delete; Request& operator=(Request&&) = delete; - ~Request() = default; + ~Request() override = default; /** @brief Constructor * @@ -168,7 +168,7 @@ * * @return return PLDM_SUCCESS on success and PLDM_ERROR otherwise */ - int send() const + int send() const override { if (verbose) {